third_party/WebKit/Source/platform/graphics/DrawLooperBuilder.cpp - Issue 1438043012: Avoid int coercion of box-shadow args

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/DrawLooperBuilder.cpp

Issue 1438043012: Avoid int coercion of box-shadow args (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mac theme update, subpixel test Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/DrawLooperBuilder.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/DrawLooperBuilder.cpp b/third_party/WebKit/Source/platform/graphics/DrawLooperBuilder.cpp

index fc1c64856c8bcca7584a393d12c788f95f820a97..7c16dc9a90c3e788fe36440b562ef4d324e9cdf5 100644

--- a/third_party/WebKit/Source/platform/graphics/DrawLooperBuilder.cpp

+++ b/third_party/WebKit/Source/platform/graphics/DrawLooperBuilder.cpp

@@ -67,9 +67,7 @@ void DrawLooperBuilder::addUnmodifiedContent()

void DrawLooperBuilder::addShadow(const FloatSize& offset, float blur, const Color& color,

ShadowTransformMode shadowTransformMode, ShadowAlphaMode shadowAlphaMode)

{

- // Negative blurs are not allowed, so just pin the value to 0

- if (blur < 0)

- blur = 0;

+ ASSERT(blur >= 0);

// Detect when there's no effective shadow.

if (!color.alpha())