third_party/WebKit/Source/core/paint/ThemePainterMac.mm - Issue 1438043012: Avoid int coercion of box-shadow args

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/ThemePainterMac.mm

Issue 1438043012: Avoid int coercion of box-shadow args (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mac theme update, subpixel test Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/ThemePainterMac.mm

diff --git a/third_party/WebKit/Source/core/paint/ThemePainterMac.mm b/third_party/WebKit/Source/core/paint/ThemePainterMac.mm

index 2c9ae64fcd0415694174c9362855c74e0022d8d5..681dcf653f1534ec380de0faf3a0c7edd40b9ab6 100644

--- a/third_party/WebKit/Source/core/paint/ThemePainterMac.mm

+++ b/third_party/WebKit/Source/core/paint/ThemePainterMac.mm

@@ -347,10 +347,10 @@ bool ThemePainterMac::paintSliderTrack(const LayoutObject& o, const PaintInfo& p

FloatRoundedRect fillRect(fillBounds, fillRadius, fillRadius, fillRadius, fillRadius);

paintInfo.context->fillRoundedRect(fillRect, fillColor);

- IntSize shadowOffset(isVerticalSlider ? 1 : 0,

- isVerticalSlider ? 0 : 1);

- int shadowBlur = 3;

- int shadowSpread = 0;

+ FloatSize shadowOffset(isVerticalSlider ? 1 : 0,

+ isVerticalSlider ? 0 : 1);

+ float shadowBlur = 3;

+ float shadowSpread = 0;

paintInfo.context->save();

paintInfo.context->drawInnerShadow(fillRect, shadowColor, shadowOffset, shadowBlur, shadowSpread);

paintInfo.context->restore();