Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: components/ntp_suggestions/ntp_suggestions_service.h

Issue 1438043008: Creating the NTP snippet service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_suggestions/ntp_suggestions_service.h
diff --git a/components/ntp_suggestions/ntp_suggestions_service.h b/components/ntp_suggestions/ntp_suggestions_service.h
new file mode 100644
index 0000000000000000000000000000000000000000..6572eecd08926f992d590a4ab9db852b1767071d
--- /dev/null
+++ b/components/ntp_suggestions/ntp_suggestions_service.h
@@ -0,0 +1,35 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+#ifndef COMPONENTS_NTP_SUGGESTIONS_NTP_SUGGESTIONS_SERVICE_H_
sdefresne 2015/11/17 13:57:29 nit: blank line before include guards seems to be
noyau (Ping after 24h) 2015/11/17 17:00:34 Done.
+#define COMPONENTS_NTP_SUGGESTIONS_NTP_SUGGESTIONS_SERVICE_H_
+
+#include <string>
+
+#include "base/macros.h"
+#include "components/keyed_service/core/keyed_service.h"
+
+namespace ntp_suggestions {
+
+// Stores and vend fresh content data for the NTP.
+class NTPSuggestionsService : public KeyedService {
+ public:
+ // |application_language_code| should be a ISO 639-1 compliant string. Aka
+ // 'en' or 'en-US'. Note that this code should only specify the language, not
+ // the locale, so 'en_US' (english language with US locale) and 'en-GB_US'
+ // (British english person in the US) are not language code.
+ NTPSuggestionsService(const std::string& application_language_code);
sdefresne 2015/11/17 13:57:29 nit: NTPSuggestionsService(const std::string& app
noyau (Ping after 24h) 2015/11/17 17:00:34 I used the same order as the superclass on purpose
+ void Shutdown() override;
+ ~NTPSuggestionsService() override;
+
+ // TODO(noyau): Add API.
sdefresne 2015/11/17 13:57:29 nit: TODO(crbug/xxxxx): Add API.
noyau (Ping after 24h) 2015/11/17 17:00:34 Done.
+ private:
+ // The ISO 639-1 code of the language used by the application.
+ const std::string application_language_code_;
+
+ DISALLOW_COPY_AND_ASSIGN(NTPSuggestionsService);
+};
+
+} // namespace ntp_suggestions
+
+#endif // COMPONENTS_NTP_SUGGESTIONS_NTP_SUGGESTIONS_SERVICE_H_

Powered by Google App Engine
This is Rietveld 408576698