Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Side by Side Diff: components/ntp_suggestions/ntp_suggestions_service.h

Issue 1438043008: Creating the NTP snippet service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4 #ifndef COMPONENTS_NTP_SUGGESTIONS_NTP_SUGGESTIONS_SERVICE_H_
sdefresne 2015/11/17 13:57:29 nit: blank line before include guards seems to be
noyau (Ping after 24h) 2015/11/17 17:00:34 Done.
5 #define COMPONENTS_NTP_SUGGESTIONS_NTP_SUGGESTIONS_SERVICE_H_
6
7 #include <string>
8
9 #include "base/macros.h"
10 #include "components/keyed_service/core/keyed_service.h"
11
12 namespace ntp_suggestions {
13
14 // Stores and vend fresh content data for the NTP.
15 class NTPSuggestionsService : public KeyedService {
16 public:
17 // |application_language_code| should be a ISO 639-1 compliant string. Aka
18 // 'en' or 'en-US'. Note that this code should only specify the language, not
19 // the locale, so 'en_US' (english language with US locale) and 'en-GB_US'
20 // (British english person in the US) are not language code.
21 NTPSuggestionsService(const std::string& application_language_code);
sdefresne 2015/11/17 13:57:29 nit: NTPSuggestionsService(const std::string& app
noyau (Ping after 24h) 2015/11/17 17:00:34 I used the same order as the superclass on purpose
22 void Shutdown() override;
23 ~NTPSuggestionsService() override;
24
25 // TODO(noyau): Add API.
sdefresne 2015/11/17 13:57:29 nit: TODO(crbug/xxxxx): Add API.
noyau (Ping after 24h) 2015/11/17 17:00:34 Done.
26 private:
27 // The ISO 639-1 code of the language used by the application.
28 const std::string application_language_code_;
29
30 DISALLOW_COPY_AND_ASSIGN(NTPSuggestionsService);
31 };
32
33 } // namespace ntp_suggestions
34
35 #endif // COMPONENTS_NTP_SUGGESTIONS_NTP_SUGGESTIONS_SERVICE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698