[Background Sync] Align exposed API with spec

third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp

Index: third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp
diff --git a/third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp b/third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp
index c0cd78e2147e25497f745ea0b814a96707589e34..41f5f31e394fedb622c6bd3db9e3fe532c1f0258 100644
--- a/third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp
+++ b/third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp
@@ -120,20 +120,14 @@ SyncGetRegistrationsCallbacks::~SyncGetRegistrationsCallbacks()
 
 void SyncGetRegistrationsCallbacks::onSuccess(const WebVector<WebSyncRegistration*>& webSyncRegistrations)
 {
-    Vector<OwnPtr<WebSyncRegistration>> registrations;
-    for (WebSyncRegistration* r : webSyncRegistrations) {
-        registrations.append(adoptPtr(r));
-    }

[jkarlin, 2015/11/13 01:32:18]

We now have a memory leak, webSyncRegistration's elements aren't being deleted.

[iclelland, 2015/11/13 15:26:19]

Maybe it's early and I haven't had enough coffee yet, but I'm not seeing it --
the elements are deleted when the vector is destroyed, which happens when it
goes out of scope at the end of BackgroundSyncProvider::GetRegistrationCallback
(after this method returns) We don't use the elements for anything except
copying their tags, so there's no need to adopt them here, as far as I can see.

(But I haven't had the coffee, so I'll come back and look again afterwards.
Maybe I'll run the LSan tests in the meantime)

[jkarlin, 2015/11/13 17:00:42]

My bad. I didn't realize that WebVector deleted its elements. 

     if (!m_resolver->executionContext() || m_resolver->executionContext()->activeDOMObjectsAreStopped()) {
         return;
     }
-
-    HeapVector<Member<SyncRegistration>> syncRegistrations;
-    for (auto& r : registrations) {
-        SyncRegistration* reg = SyncRegistration::take(m_resolver.get(), r.release(), m_serviceWorkerRegistration);
-        syncRegistrations.append(reg);
+    Vector<String> tags;
+    for (WebSyncRegistration* r : webSyncRegistrations) {

[jkarlin, 2015/11/13 01:32:18]

const WebSyncRegistration*

[iclelland, 2015/11/13 15:26:19]

Done.

[jkarlin, 2015/11/13 17:00:42]

I don't see the change.

[iclelland, 2015/11/13 20:49:24]

Okay, *really* done now.

+        tags.append(r->tag);
     }
-    m_resolver->resolve(syncRegistrations);
+    m_resolver->resolve(tags);
 }
 
 void SyncGetRegistrationsCallbacks::onError(const WebSyncError& error)