[Background Sync] Align exposed API with spec

third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/background_sync/SyncCallbacks.h"
 
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "modules/background_sync/SyncError.h"
 #include "modules/background_sync/SyncRegistration.h"
@@ skipping 102 matching lines @@
     ASSERT(m_resolver);
     ASSERT(m_serviceWorkerRegistration);
 }
 
 SyncGetRegistrationsCallbacks::~SyncGetRegistrationsCallbacks()
 {
 }
 
 void SyncGetRegistrationsCallbacks::onSuccess(const WebVector<WebSyncRegistration*>& webSyncRegistrations)
 {
-    Vector<OwnPtr<WebSyncRegistration>> registrations;
-    for (WebSyncRegistration* r : webSyncRegistrations) {
-        registrations.append(adoptPtr(r));
-    }

[jkarlin, 2015/11/13 01:32:18]

We now have a memory leak, webSyncRegistration's elements aren't being deleted.

[iclelland, 2015/11/13 15:26:19]

Maybe it's early and I haven't had enough coffee yet, but I'm not seeing it --
the elements are deleted when the vector is destroyed, which happens when it
goes out of scope at the end of BackgroundSyncProvider::GetRegistrationCallback
(after this method returns) We don't use the elements for anything except
copying their tags, so there's no need to adopt them here, as far as I can see.

(But I haven't had the coffee, so I'll come back and look again afterwards.
Maybe I'll run the LSan tests in the meantime)

[jkarlin, 2015/11/13 17:00:42]

My bad. I didn't realize that WebVector deleted its elements. 

     if (!m_resolver->executionContext() || m_resolver->executionContext()->activeDOMObjectsAreStopped()) {
         return;
     }
-
-    HeapVector<Member<SyncRegistration>> syncRegistrations;
-    for (auto& r : registrations) {
-        SyncRegistration* reg = SyncRegistration::take(m_resolver.get(), r.release(), m_serviceWorkerRegistration);
-        syncRegistrations.append(reg);
+    Vector<String> tags;
+    for (WebSyncRegistration* r : webSyncRegistrations) {

[jkarlin, 2015/11/13 01:32:18]

const WebSyncRegistration*

[iclelland, 2015/11/13 15:26:19]

Done.

[jkarlin, 2015/11/13 17:00:42]

I don't see the change.

[iclelland, 2015/11/13 20:49:24]

Okay, *really* done now.

+        tags.append(r->tag);
     }
-    m_resolver->resolve(syncRegistrations);
+    m_resolver->resolve(tags);
 }
 
 void SyncGetRegistrationsCallbacks::onError(const WebSyncError& error)
 {
     if (!m_resolver->executionContext() || m_resolver->executionContext()->activeDOMObjectsAreStopped()) {
         return;
     }
     m_resolver->reject(SyncError::take(m_resolver.get(), error));
 }
 
@@ skipping 36 matching lines @@
         return "denied";
     case WebSyncPermissionStatusPrompt:
         return "prompt";
     }
 
     ASSERT_NOT_REACHED();
     return "denied";
 }
 
 } // namespace blink