Issue 1437863005: Merge to XFA: Replace CJS_Parameters with std::vector<CJS_Value>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1437863005: Merge to XFA: Replace CJS_Parameters with std::vector<CJS_Value>. (Closed)

Created:
5 years, 1 month ago by Lei Zhang

Modified:
5 years, 1 month ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

More Reviews

Description

Merge to XFA: Replace CJS_Parameters with std::vector<CJS_Value>. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1437713003 . (cherry picked from commit f20a34c0f2dfca49f735a0f11147254c26831e7c) Committed: https://pdfium.googlesource.com/pdfium/+/945fdb70f022952e9ed53847649226369352920a

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+306 lines, -294 lines)			Patch
M	fpdfsdk/src/javascript/Document.h	View	1 chunk	+40 lines, -40 lines	0 comments	Download
M	fpdfsdk/src/javascript/Document.cpp	View	36 chunks	+40 lines, -40 lines	0 comments	Download
M	fpdfsdk/src/javascript/Field.h	View	1 chunk	+26 lines, -26 lines	0 comments	Download
M	fpdfsdk/src/javascript/Field.cpp	View	12 chunks	+26 lines, -26 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Define.h	View	4 chunks	+7 lines, -5 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Value.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/javascript/PublicMethods.h	View	1 chunk	+22 lines, -22 lines	0 comments	Download
M	fpdfsdk/src/javascript/PublicMethods.cpp	View	20 chunks	+75 lines, -63 lines	0 comments	Download
M	fpdfsdk/src/javascript/app.h	View	1 chunk	+21 lines, -21 lines	0 comments	Download
M	fpdfsdk/src/javascript/app.cpp	View	16 chunks	+21 lines, -21 lines	0 comments	Download
M	fpdfsdk/src/javascript/color.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/javascript/color.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/javascript/console.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	fpdfsdk/src/javascript/console.cpp	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	fpdfsdk/src/javascript/global.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/src/javascript/global.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/src/javascript/report.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/javascript/report.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/javascript/util.h	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	fpdfsdk/src/javascript/util.cpp	View	5 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

5 years, 1 month ago (2015-11-11 18:18:22 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
945fdb70f022952e9ed53847649226369352920a (presubmit successful).

Expand Messages | Collapse Messages