Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1437713003: Replace CJS_Parameters with std::vector<CJS_Value>. (Closed)

Created:
5 years, 1 month ago by Lei Zhang
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@todo
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -294 lines) Patch
M fpdfsdk/src/javascript/Document.h View 1 chunk +40 lines, -40 lines 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 36 chunks +40 lines, -40 lines 0 comments Download
M fpdfsdk/src/javascript/Field.h View 1 chunk +26 lines, -26 lines 0 comments Download
M fpdfsdk/src/javascript/Field.cpp View 12 chunks +26 lines, -26 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Define.h View 4 chunks +7 lines, -5 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Value.h View 1 chunk +0 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/PublicMethods.h View 1 chunk +22 lines, -22 lines 0 comments Download
M fpdfsdk/src/javascript/PublicMethods.cpp View 20 chunks +75 lines, -63 lines 0 comments Download
M fpdfsdk/src/javascript/app.h View 1 chunk +21 lines, -21 lines 0 comments Download
M fpdfsdk/src/javascript/app.cpp View 16 chunks +21 lines, -21 lines 0 comments Download
M fpdfsdk/src/javascript/color.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/color.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/console.h View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/console.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/global.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/global.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/report.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/report.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/util.h View 1 chunk +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/javascript/util.cpp View 5 chunks +5 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 1432863004 Patch 40001

Messages

Total messages: 4 (1 generated)
Lei Zhang
This is just sed + git cl format.
5 years, 1 month ago (2015-11-11 02:37:36 UTC) #2
Tom Sepez
lgtm
5 years, 1 month ago (2015-11-11 17:41:02 UTC) #3
Lei Zhang
5 years, 1 month ago (2015-11-11 18:11:25 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
f20a34c0f2dfca49f735a0f11147254c26831e7c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698