Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1437843002: Move GrBatchFlushState from GrDrawTarget to GrDrawingManager (Closed)

Created:
5 years, 1 month ago by robertphillips
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move GrBatchFlushState from GrDrawTarget to GrDrawingManager This CL: moves the flushState disables immediate mode (it was proving difficult to implement) also moves the program unit test to the drawing manager BUG=skia:4094 TBR=bsalomon@google.com Committed: https://skia.googlesource.com/skia/+/a13e202563979fd5076936606dcc1d660da8c632

Patch Set 1 #

Patch Set 2 : Disable immediate mode #

Patch Set 3 : clean up #

Patch Set 4 : readd white space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -57 lines) Patch
M gm/beziereffects.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/convexpolyeffect.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M include/gpu/GrContext.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 2 5 chunks +4 lines, -13 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 2 5 chunks +6 lines, -19 lines 0 comments Download
M src/gpu/GrDrawingManager.h View 1 3 chunks +8 lines, -4 lines 0 comments Download
M src/gpu/GrDrawingManager.cpp View 1 2 4 chunks +23 lines, -4 lines 0 comments Download
M tests/GLProgramsTest.cpp View 7 chunks +17 lines, -12 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
robertphillips
5 years, 1 month ago (2015-11-11 18:01:39 UTC) #4
joshualitt
On 2015/11/11 18:01:39, robertphillips wrote: LGTM + nit
5 years, 1 month ago (2015-11-11 19:37:45 UTC) #5
robertphillips
Will land '\n' removal in follow up (readding immediate mode)
5 years, 1 month ago (2015-11-11 19:42:53 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437843002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437843002/60001
5 years, 1 month ago (2015-11-11 19:43:11 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-11 19:53:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437843002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437843002/60001
5 years, 1 month ago (2015-11-11 19:57:01 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/3817)
5 years, 1 month ago (2015-11-11 19:58:06 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437843002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437843002/60001
5 years, 1 month ago (2015-11-11 20:00:17 UTC) #18
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 20:01:16 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/a13e202563979fd5076936606dcc1d660da8c632

Powered by Google App Engine
This is Rietveld 408576698