Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: components/variations/variations_seed_store.cc

Issue 1437833004: Implemented clearing Java prefs after pulling variations first run seed from Java to C++ side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/variations/variations_seed_store.cc
diff --git a/components/variations/variations_seed_store.cc b/components/variations/variations_seed_store.cc
index 84dca7e3ce91341fab819cdd6a711b0d122de543..8400a3ffe9cd418fee2f8056a31e5b3e0689a5df 100644
--- a/components/variations/variations_seed_store.cc
+++ b/components/variations/variations_seed_store.cc
@@ -12,6 +12,7 @@
#include "base/sha1.h"
#include "base/strings/string_number_conversions.h"
#include "components/compression/compression_utils.h"
+#include "components/variations/android/variations_seed_bridge.h"
#include "components/variations/pref_names.h"
#include "components/variations/proto/variations_seed.pb.h"
#include "crypto/signature_verifier.h"
@@ -369,6 +370,7 @@ void VariationsSeedStore::ImportFirstRunJavaSeed() {
std::string seed_country;
get_variations_first_run_seed_.Run(&seed_data, &seed_signature,
&seed_country);
Alexei Svitkine (slow) 2015/11/12 16:30:11 Per offline discussion, I suggested the below woul
Alexander Agulenko 2015/11/12 17:40:25 Done.
+ android::ClearJavaPrefs();
Alexei Svitkine (slow) 2015/11/12 16:30:11 This needs an ifdef android. Also probably the inc
Alexander Agulenko 2015/11/12 17:25:25 I am not sure that it is really necessary: the who
Alexei Svitkine (slow) 2015/11/12 17:36:28 Sorry, you're right. However, see my other comment
if (seed_data.empty()) {
RecordFirstRunResult(FIRST_RUN_SEED_IMPORT_FAIL_NO_FIRST_RUN_SEED);
return;

Powered by Google App Engine
This is Rietveld 408576698