Implemented clearing Java prefs after pulling variations first run seed from Java to C++ side

components/variations/variations_seed_store.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/variations/variations_seed_store.h"
 
 #include "base/base64.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/numerics/safe_math.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
 #include "base/sha1.h"
 #include "base/strings/string_number_conversions.h"
 #include "components/compression/compression_utils.h"
+#include "components/variations/android/variations_seed_bridge.h"
 #include "components/variations/pref_names.h"
 #include "components/variations/proto/variations_seed.pb.h"
 #include "crypto/signature_verifier.h"
 #include "third_party/protobuf/src/google/protobuf/io/coded_stream.h"
 
 namespace variations {
 
 namespace {
 
 // Signature verification is disabled on mobile platforms for now, since it
@@ skipping 336 matching lines @@
   DVLOG(1) << "Importing first run seed from Java preferences.";
   if (get_variations_first_run_seed_.is_null()) {
     RecordFirstRunResult(FIRST_RUN_SEED_IMPORT_FAIL_NO_CALLBACK);
     return;
   }
 
   std::string seed_data;
   std::string seed_signature;
   std::string seed_country;
   get_variations_first_run_seed_.Run(&seed_data, &seed_signature,
                                      &seed_country);

[Alexei Svitkine (slow), 2015/11/12 16:30:11]

Per offline discussion, I suggested the below would be done when storing the
seed if the current seed is empty.

[Alexander Agulenko, 2015/11/12 17:40:25]

Done.

+  android::ClearJavaPrefs();

[Alexei Svitkine (slow), 2015/11/12 16:30:11]

This needs an ifdef android. Also probably the include.

[Alexander Agulenko, 2015/11/12 17:25:25]

I am not sure that it is really necessary: the whole function is wrapped by
ifdef android, so there is no sense in wrapping a piece of code inside it.

[Alexei Svitkine (slow), 2015/11/12 17:36:28]

Sorry, you're right. However, see my other comment about moving this to a
different location, where it likely will need to be ifdefd.

   if (seed_data.empty()) {
     RecordFirstRunResult(FIRST_RUN_SEED_IMPORT_FAIL_NO_FIRST_RUN_SEED);
     return;
   }
 
   // TODO(agulenko): Pull actual time from the response.
   base::Time current_time = base::Time::Now();
 
   // TODO(agulenko): Support gzip compressed seed.
   if (!StoreSeedData(seed_data, seed_signature, seed_country, current_time,
@@ skipping 148 matching lines @@
   }
   return true;
 }
 
 void VariationsSeedStore::ReportUnsupportedSeedFormatError() {
   RecordSeedStoreHistogram(
       VARIATIONS_SEED_STORE_FAILED_UNSUPPORTED_SEED_FORMAT);
 }
 
 }  // namespace variations