Fix -Wunused-parameter errors in SkCodec.h in Android

Fix -Wunused-parameter errors in SkCodec.h in Android

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/33bee090fa332b2f3db366ae0ecc3231bd8e112e

[msarett, 2015-11-11 15:08:56]

msarett@google.com changed reviewers:
+ djsollen@google.com, scroggo@google.com

[msarett, 2015-11-11 15:08:56]

These errors came up when I tried to include SkCodec.h, in order to use
SkCodec::ZeroInitialized.

[scroggo, 2015-11-11 18:30:12]

lgtm

> Fix -Wunused-parameter errors in SkCodec.h in Android

I'm confused - do we not already build codec with that warning as error? Why did
including it elsewhere affect this? (I recall we used to accidentally build
codec without warnings as errors, but I thought we fixed that?)

On 2015/11/11 15:08:56, msarett wrote:
> These errors came up when I tried to include SkCodec.h, in order to use
> SkCodec::ZeroInitialized.

Including it in tools?

[msarett, 2015-11-11 18:42:32]

On 2015/11/11 18:30:12, scroggo wrote:
> lgtm
> 
> > Fix -Wunused-parameter errors in SkCodec.h in Android
> 
> I'm confused - do we not already build codec with that warning as error? Why
did
> including it elsewhere affect this? (I recall we used to accidentally build
> codec without warnings as errors, but I thought we fixed that?)
> 

Yeah me too.  I will figure this out.

> On 2015/11/11 15:08:56, msarett wrote:
> > These errors came up when I tried to include SkCodec.h, in order to use
> > SkCodec::ZeroInitialized.
> 
> Including it in tools?

Including it in frameworks/base/core/jni/GraphicsJNI.h for this CL.
https://googleplex-android-review.git.corp.google.com/#/c/810173/

[msarett, 2015-11-11 19:36:55]

On 2015/11/11 18:42:32, msarett wrote:
> On 2015/11/11 18:30:12, scroggo wrote:
> > lgtm
> > 
> > > Fix -Wunused-parameter errors in SkCodec.h in Android
> > 
> > I'm confused - do we not already build codec with that warning as error? Why
> did
> > including it elsewhere affect this? (I recall we used to accidentally build
> > codec without warnings as errors, but I thought we fixed that?)
> > 
> 
> Yeah me too.  I will figure this out.
> 

-Wunused-parameter is included in -Wextra.

In common_conditions.gypi, everywhere we have -Wextra, we also have
-Wno-unused-parameter, so I think we explicitly don't care about this
warning.

Having said that, in tools, we test that none of our public headers
have unused parameters.  Pretty much for exactly the case we just
ran into.  I added include/codec so it is now part of the test.

> > On 2015/11/11 15:08:56, msarett wrote:
> > > These errors came up when I tried to include SkCodec.h, in order to use
> > > SkCodec::ZeroInitialized.
> > 
> > Including it in tools?
> 
> Including it in frameworks/base/core/jni/GraphicsJNI.h for this CL.
> https://googleplex-android-review.git.corp.google.com/#/c/810173/

PTAL

[scroggo, 2015-11-11 20:28:58]

On 2015/11/11 19:36:55, msarett wrote:
> On 2015/11/11 18:42:32, msarett wrote:
> > On 2015/11/11 18:30:12, scroggo wrote:
> > > lgtm
> > > 
> > > > Fix -Wunused-parameter errors in SkCodec.h in Android
> > > 
> > > I'm confused - do we not already build codec with that warning as error?
Why
> > did
> > > including it elsewhere affect this? (I recall we used to accidentally
build
> > > codec without warnings as errors, but I thought we fixed that?)
> > > 
> > 
> > Yeah me too.  I will figure this out.
> > 
> 
> -Wunused-parameter is included in -Wextra.
> 
> In common_conditions.gypi, everywhere we have -Wextra, we also have
> -Wno-unused-parameter, so I think we explicitly don't care about this
> warning.
> 
> Having said that, in tools, we test that none of our public headers
> have unused parameters.  Pretty much for exactly the case we just
> ran into.  I added include/codec so it is now part of the test.
> 
> > > On 2015/11/11 15:08:56, msarett wrote:
> > > > These errors came up when I tried to include SkCodec.h, in order to use
> > > > SkCodec::ZeroInitialized.
> > > 
> > > Including it in tools?
> > 
> > Including it in frameworks/base/core/jni/GraphicsJNI.h for this CL.
> > https://googleplex-android-review.git.corp.google.com/#/c/810173/
> 
> PTAL

LGTM, and thanks for the explanation!

Derek, API?

[djsollen, 2015-11-11 20:30:42]

lgtm

[msarett, 2015-11-11 20:32:05]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2015-11-11 20:32:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1437823004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1437823004/20001

[commit-bot: I haz the power, 2015-11-11 20:43:10]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/33bee090fa332b2f3db366ae0ecc3231bd8e112e