Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: fpdfsdk/src/javascript/app.cpp

Issue 1437713003: Replace CJS_Parameters with std::vector<CJS_Value>. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@todo
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/src/javascript/app.h ('k') | fpdfsdk/src/javascript/color.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/src/javascript/app.cpp
diff --git a/fpdfsdk/src/javascript/app.cpp b/fpdfsdk/src/javascript/app.cpp
index d223934bbd3f50ca685ec76e9691148d5f986025..072e31f7df3a4fb032c9d5bea550ec47b94ebb09 100644
--- a/fpdfsdk/src/javascript/app.cpp
+++ b/fpdfsdk/src/javascript/app.cpp
@@ -228,7 +228,7 @@ FX_BOOL app::language(IJS_Context* cc,
// note:
// CFDF_Document * CPDFDoc_Environment::NewFDF();
FX_BOOL app::newFDF(IJS_Context* cc,
- const CJS_Parameters& params,
+ const std::vector<CJS_Value>& params,
CJS_Value& vRet,
CFX_WideString& sError) {
return TRUE;
@@ -240,14 +240,14 @@ FX_BOOL app::newFDF(IJS_Context* cc,
// CFDF_Document * CPDFDoc_Environment::OpenFDF(string strPath,bool bUserConv);
FX_BOOL app::openFDF(IJS_Context* cc,
- const CJS_Parameters& params,
+ const std::vector<CJS_Value>& params,
CJS_Value& vRet,
CFX_WideString& sError) {
return TRUE;
}
FX_BOOL app::alert(IJS_Context* cc,
- const CJS_Parameters& params,
+ const std::vector<CJS_Value>& params,
CJS_Value& vRet,
CFX_WideString& sError) {
int iSize = params.size();
@@ -342,7 +342,7 @@ FX_BOOL app::alert(IJS_Context* cc,
}
FX_BOOL app::beep(IJS_Context* cc,
- const CJS_Parameters& params,
+ const std::vector<CJS_Value>& params,
CJS_Value& vRet,
CFX_WideString& sError) {
if (params.size() == 1) {
@@ -358,14 +358,14 @@ FX_BOOL app::beep(IJS_Context* cc,
}
FX_BOOL app::findComponent(IJS_Context* cc,
- const CJS_Parameters& params,
+ const std::vector<CJS_Value>& params,
CJS_Value& vRet,
CFX_WideString& sError) {
return TRUE;
}
FX_BOOL app::popUpMenuEx(IJS_Context* cc,
- const CJS_Parameters& params,
+ const std::vector<CJS_Value>& params,
CJS_Value& vRet,
CFX_WideString& sError) {
return FALSE;
@@ -376,7 +376,7 @@ FX_BOOL app::fs(IJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError) {
}
FX_BOOL app::setInterval(IJS_Context* cc,
- const CJS_Parameters& params,
+ const std::vector<CJS_Value>& params,
CJS_Value& vRet,
CFX_WideString& sError) {
CJS_Context* pContext = (CJS_Context*)cc;
@@ -412,7 +412,7 @@ FX_BOOL app::setInterval(IJS_Context* cc,
}
FX_BOOL app::setTimeOut(IJS_Context* cc,
- const CJS_Parameters& params,
+ const std::vector<CJS_Value>& params,
CJS_Value& vRet,
CFX_WideString& sError) {
if (params.size() > 2 || params.size() == 0) {
@@ -453,7 +453,7 @@ FX_BOOL app::setTimeOut(IJS_Context* cc,
}
FX_BOOL app::clearTimeOut(IJS_Context* cc,
- const CJS_Parameters& params,
+ const std::vector<CJS_Value>& params,
CJS_Value& vRet,
CFX_WideString& sError) {
CJS_Context* pContext = (CJS_Context*)cc;
@@ -489,7 +489,7 @@ FX_BOOL app::clearTimeOut(IJS_Context* cc,
}
FX_BOOL app::clearInterval(IJS_Context* cc,
- const CJS_Parameters& params,
+ const std::vector<CJS_Value>& params,
CJS_Value& vRet,
CFX_WideString& sError) {
CJS_Context* pContext = (CJS_Context*)cc;
@@ -525,7 +525,7 @@ FX_BOOL app::clearInterval(IJS_Context* cc,
}
FX_BOOL app::execMenuItem(IJS_Context* cc,
- const CJS_Parameters& params,
+ const std::vector<CJS_Value>& params,
CJS_Value& vRet,
CFX_WideString& sError) {
return FALSE;
@@ -562,7 +562,7 @@ void app::RunJsScript(CJS_Runtime* pRuntime, const CFX_WideString& wsScript) {
}
FX_BOOL app::goBack(IJS_Context* cc,
- const CJS_Parameters& params,
+ const std::vector<CJS_Value>& params,
CJS_Value& vRet,
CFX_WideString& sError) {
// Not supported.
@@ -570,7 +570,7 @@ FX_BOOL app::goBack(IJS_Context* cc,
}
FX_BOOL app::goForward(IJS_Context* cc,
- const CJS_Parameters& params,
+ const std::vector<CJS_Value>& params,
CJS_Value& vRet,
CFX_WideString& sError) {
// Not supported.
@@ -578,7 +578,7 @@ FX_BOOL app::goForward(IJS_Context* cc,
}
FX_BOOL app::mailMsg(IJS_Context* cc,
- const CJS_Parameters& params,
+ const std::vector<CJS_Value>& params,
CJS_Value& vRet,
CFX_WideString& sError) {
if (params.size() < 1)
@@ -645,7 +645,7 @@ FX_BOOL app::mailMsg(IJS_Context* cc,
}
FX_BOOL app::launchURL(IJS_Context* cc,
- const CJS_Parameters& params,
+ const std::vector<CJS_Value>& params,
CJS_Value& vRet,
CFX_WideString& sError) {
// Unsafe, not supported.
@@ -671,14 +671,14 @@ FX_BOOL app::fullscreen(IJS_Context* cc,
}
FX_BOOL app::popUpMenu(IJS_Context* cc,
- const CJS_Parameters& params,
+ const std::vector<CJS_Value>& params,
CJS_Value& vRet,
CFX_WideString& sError) {
return FALSE;
}
FX_BOOL app::browseForDoc(IJS_Context* cc,
- const CJS_Parameters& params,
+ const std::vector<CJS_Value>& params,
CJS_Value& vRet,
CFX_WideString& sError) {
// Unsafe, not supported.
@@ -704,21 +704,21 @@ CFX_WideString app::SysPathToPDFPath(const CFX_WideString& sOldPath) {
}
FX_BOOL app::newDoc(IJS_Context* cc,
- const CJS_Parameters& params,
+ const std::vector<CJS_Value>& params,
CJS_Value& vRet,
CFX_WideString& sError) {
return FALSE;
}
FX_BOOL app::openDoc(IJS_Context* cc,
- const CJS_Parameters& params,
+ const std::vector<CJS_Value>& params,
CJS_Value& vRet,
CFX_WideString& sError) {
return FALSE;
}
FX_BOOL app::response(IJS_Context* cc,
- const CJS_Parameters& params,
+ const std::vector<CJS_Value>& params,
CJS_Value& vRet,
CFX_WideString& sError) {
CFX_WideString swQuestion = L"";
@@ -803,7 +803,7 @@ FX_BOOL app::media(IJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError) {
}
FX_BOOL app::execDialog(IJS_Context* cc,
- const CJS_Parameters& params,
+ const std::vector<CJS_Value>& params,
CJS_Value& vRet,
CFX_WideString& sError) {
return TRUE;
« no previous file with comments | « fpdfsdk/src/javascript/app.h ('k') | fpdfsdk/src/javascript/color.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698