Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 1437483002: Removed virtualenv from depot_tools (Closed)

Created:
5 years, 1 month ago by Sergiy Byelozyorov
Modified:
5 years, 1 month ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -7072 lines) Patch
M .gitignore View 1 chunk +0 lines, -3 lines 0 comments Download
M PRESUBMIT.py View 1 chunk +1 line, -2 lines 0 comments Download
D bootstrap/.gitignore View 1 chunk +0 lines, -2 lines 0 comments Download
D bootstrap/bootstrap.py View 1 chunk +0 lines, -234 lines 0 comments Download
D bootstrap/deps.pyl View 1 chunk +0 lines, -15 lines 0 comments Download
D bootstrap/gclient.bat View 1 chunk +0 lines, -22 lines 0 comments Download
D bootstrap/util.py View 1 chunk +0 lines, -87 lines 0 comments Download
D bootstrap/virtualenv/.gitignore View 1 chunk +0 lines, -10 lines 0 comments Download
D bootstrap/virtualenv/.travis.yml View 1 chunk +0 lines, -28 lines 0 comments Download
D bootstrap/virtualenv/AUTHORS.txt View 1 chunk +0 lines, -91 lines 0 comments Download
D bootstrap/virtualenv/CONTRIBUTING.rst View 1 chunk +0 lines, -21 lines 0 comments Download
D bootstrap/virtualenv/LICENSE.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D bootstrap/virtualenv/MANIFEST.in View 1 chunk +0 lines, -11 lines 0 comments Download
D bootstrap/virtualenv/README.rst View 1 chunk +0 lines, -10 lines 0 comments Download
D bootstrap/virtualenv/bin/rebuild-script.py View 1 chunk +0 lines, -71 lines 0 comments Download
D bootstrap/virtualenv/docs/Makefile View 1 chunk +0 lines, -130 lines 0 comments Download
D bootstrap/virtualenv/docs/changes.rst View 1 chunk +0 lines, -747 lines 0 comments Download
D bootstrap/virtualenv/docs/conf.py View 1 chunk +0 lines, -149 lines 0 comments Download
D bootstrap/virtualenv/docs/development.rst View 1 chunk +0 lines, -61 lines 0 comments Download
D bootstrap/virtualenv/docs/index.rst View 1 chunk +0 lines, -137 lines 0 comments Download
D bootstrap/virtualenv/docs/installation.rst View 1 chunk +0 lines, -58 lines 0 comments Download
D bootstrap/virtualenv/docs/make.bat View 1 chunk +0 lines, -170 lines 0 comments Download
D bootstrap/virtualenv/docs/reference.rst View 1 chunk +0 lines, -256 lines 0 comments Download
D bootstrap/virtualenv/docs/userguide.rst View 1 chunk +0 lines, -249 lines 0 comments Download
D bootstrap/virtualenv/scripts/virtualenv View 1 chunk +0 lines, -3 lines 0 comments Download
D bootstrap/virtualenv/setup.py View 1 chunk +0 lines, -111 lines 0 comments Download
D bootstrap/virtualenv/tests/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D bootstrap/virtualenv/tests/test_activate.sh View 1 chunk +0 lines, -94 lines 0 comments Download
D bootstrap/virtualenv/tests/test_activate_expected.output View 1 chunk +0 lines, -2 lines 0 comments Download
D bootstrap/virtualenv/tests/test_virtualenv.py View 1 chunk +0 lines, -139 lines 0 comments Download
D bootstrap/virtualenv/tests/tox.ini View 1 chunk +0 lines, -12 lines 0 comments Download
D bootstrap/virtualenv/tox.ini View 1 chunk +0 lines, -17 lines 0 comments Download
D bootstrap/virtualenv/virtualenv.py View 1 chunk +0 lines, -2367 lines 0 comments Download
D bootstrap/virtualenv/virtualenv_embedded/activate.bat View 1 chunk +0 lines, -26 lines 0 comments Download
D bootstrap/virtualenv/virtualenv_embedded/activate.csh View 1 chunk +0 lines, -42 lines 0 comments Download
D bootstrap/virtualenv/virtualenv_embedded/activate.fish View 1 chunk +0 lines, -74 lines 0 comments Download
D bootstrap/virtualenv/virtualenv_embedded/activate.ps1 View 1 chunk +0 lines, -150 lines 0 comments Download
D bootstrap/virtualenv/virtualenv_embedded/activate.sh View 1 chunk +0 lines, -80 lines 0 comments Download
D bootstrap/virtualenv/virtualenv_embedded/activate_this.py View 1 chunk +0 lines, -34 lines 0 comments Download
D bootstrap/virtualenv/virtualenv_embedded/deactivate.bat View 1 chunk +0 lines, -20 lines 0 comments Download
D bootstrap/virtualenv/virtualenv_embedded/distutils.cfg View 1 chunk +0 lines, -6 lines 0 comments Download
D bootstrap/virtualenv/virtualenv_embedded/distutils-init.py View 1 chunk +0 lines, -101 lines 0 comments Download
D bootstrap/virtualenv/virtualenv_embedded/site.py View 1 chunk +0 lines, -758 lines 0 comments Download
D bootstrap/virtualenv/virtualenv_support/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D bootstrap/virtualenv/virtualenv_support/pip-6.0-py2.py3-none-any.whl View Binary file 0 comments Download
D bootstrap/virtualenv/virtualenv_support/setuptools-8.2.1-py2.py3-none-any.whl View Binary file 0 comments Download
D bootstrap/win/README.google View 1 chunk +0 lines, -16 lines 0 comments Download
D bootstrap/win/get_file.js View 1 chunk +0 lines, -119 lines 0 comments Download
D bootstrap/win/pylint.new.bat View 1 chunk +0 lines, -7 lines 0 comments Download
D bootstrap/win/python276.new.bat View 1 chunk +0 lines, -8 lines 0 comments Download
D bootstrap/win/svn.new.bat View 1 chunk +0 lines, -4 lines 0 comments Download
D bootstrap/win/svnversion.new.bat View 1 chunk +0 lines, -4 lines 0 comments Download
D bootstrap/win/unzip.js View 1 chunk +0 lines, -91 lines 0 comments Download
D bootstrap/win/win_tools.bat View 1 chunk +0 lines, -173 lines 0 comments Download
M commit_queue View 1 chunk +1 line, -5 lines 0 comments Download
M commit_queue.bat View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/cq_client/cq_pb2.py View 1 chunk +13 lines, -5 lines 0 comments Download
M third_party/cq_client/validate_config.py View 1 chunk +8 lines, -1 line 0 comments Download
M third_party/protobuf26/README.chromium View 2 chunks +9 lines, -6 lines 0 comments Download
M update_depot_tools View 1 chunk +0 lines, -4 lines 0 comments Download
M update_depot_tools.bat View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Sergiy Byelozyorov
5 years, 1 month ago (2015-11-09 13:14:44 UTC) #3
tandrii(chromium)
lgtm
5 years, 1 month ago (2015-11-09 14:43:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437483002/1
5 years, 1 month ago (2015-11-09 14:43:47 UTC) #6
pgervais
Looks good, do you know why the patch can't be applied on the bot?
5 years, 1 month ago (2015-11-09 15:01:36 UTC) #8
Sergiy Byelozyorov
On 2015/11/09 15:01:36, pgervais wrote: > Looks good, do you know why the patch can't ...
5 years, 1 month ago (2015-11-09 15:07:08 UTC) #9
pgervais
On 2015/11/09 15:07:08, Sergiy Byelozyorov wrote: > On 2015/11/09 15:01:36, pgervais wrote: > > Looks ...
5 years, 1 month ago (2015-11-09 15:11:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437483002/1
5 years, 1 month ago (2015-11-09 15:23:48 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_presubmit/builds/247)
5 years, 1 month ago (2015-11-09 15:25:53 UTC) #14
Sergiy Byelozyorov
Committed patchset #1 (id:1) manually as 297491 (presubmit successful).
5 years, 1 month ago (2015-11-09 15:44:51 UTC) #15
dnj
5 years, 1 month ago (2015-11-09 18:29:59 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1431173002/ by dnj@chromium.org.

The reason for reverting is: This CL over-aggressively removed the Windows
bootstrap code used by /gclient.bat, which in turn downloads/installs the
Windows toolchain, including Python. Labs can no longer provision Windows bots
because of this.

update_depot_tools.bat did more than initialize the virtualenv. It also
downloaded and installed Python, Git, and Subversion on Windows systems.

I'm reverting to restore the toolchain so we can create new Windows bots. .

Powered by Google App Engine
This is Rietveld 408576698