cc/test/surface_aggregator_test_helpers.h - Issue 1437413002: cc: Remove ScopedPtrVector and cc::remove_if.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/test/surface_aggregator_test_helpers.h

Issue 1437413002: cc: Remove ScopedPtrVector and cc::remove_if. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: just the vector Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/test/surface_aggregator_test_helpers.h

diff --git a/cc/test/surface_aggregator_test_helpers.h b/cc/test/surface_aggregator_test_helpers.h

index 0848515cfdce95bc04d15fe95bb1d134da6d0fef..ae3347c74a8a9affcf2f1fe064646ec6866a8483 100644

--- a/cc/test/surface_aggregator_test_helpers.h

+++ b/cc/test/surface_aggregator_test_helpers.h

@@ -5,7 +5,8 @@

#ifndef CC_TEST_SURFACE_AGGREGATOR_TEST_HELPERS_H_

#define CC_TEST_SURFACE_AGGREGATOR_TEST_HELPERS_H_

-#include "cc/base/scoped_ptr_vector.h"

+#include <vector>

#include "cc/quads/draw_quad.h"

#include "cc/quads/render_pass_id.h"

#include "cc/surfaces/surface_id.h"

@@ -18,7 +19,7 @@ class RenderPass;

class Surface;

class TestRenderPass;

-typedef ScopedPtrVector<RenderPass> RenderPassList;

+typedef std::vector<scoped_ptr<RenderPass>> RenderPassList;

danakj 2015/11/17 01:12:18 oh cool, another copy of this typedef.

vmpstr 2015/11/17 23:26:24 These are test helpers, so I think that's ok. We a

namespace test {