Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3413)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: cc/surfaces/surface_hittest.cc

Issue 1437413002: cc: Remove ScopedPtrVector and cc::remove_if. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: just the vector Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« cc/surfaces/surface_aggregator_unittest.cc ('K') | « cc/surfaces/surface_aggregator_unittest.cc ('k') | cc/surfaces/surface_hittest_unittest.cc » ('j') | cc/test/surface_aggregator_test_helpers.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/surface_hittest.cc
diff --git a/cc/surfaces/surface_hittest.cc b/cc/surfaces/surface_hittest.cc
index 752a7088c4e44bd8d4611fac81d306a6aab41d73..d1e98672e1dbb04529011084f99481ddd85a3b4f 100644
--- a/cc/surfaces/surface_hittest.cc
+++ b/cc/surfaces/surface_hittest.cc
@@ -231,11 +231,12 @@ const RenderPass* SurfaceHittest::GetRenderPassForSurfaceById(
return nullptr;
if (!render_pass_id.IsValid())
- return frame_data->render_pass_list.back();
+ return frame_data->render_pass_list.back().get();
- for (const auto* render_pass : frame_data->render_pass_list) {
+ for (const scoped_ptr<RenderPass>& render_pass :
danakj 2015/11/17 01:12:17 auto
vmpstr 2015/11/17 23:26:24 Done.
+ frame_data->render_pass_list) {
if (render_pass->id == render_pass_id)
- return render_pass;
+ return render_pass.get();
}
return nullptr;
« cc/surfaces/surface_aggregator_unittest.cc ('K') | « cc/surfaces/surface_aggregator_unittest.cc ('k') | cc/surfaces/surface_hittest_unittest.cc » ('j') | cc/test/surface_aggregator_test_helpers.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698