Issue 14369002: Revert 194514 - New network error page: Fix resubmit warning page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14369002: Revert 194514 - New network error page: Fix resubmit warning page (Closed)

Created:
7 years, 8 months ago by mmenke

Modified:
7 years, 8 months ago

Reviewers:
mmenke

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 194514 - New network error page: Fix resubmit warning page This was causing renderer crashes when the alternate error page passed in a NULL WebURLRequest. > New network error page: Fix resubmit warning when > navigating forward / back to a page generated by a > POST that can not be retrieved from the CACHE. > > This was broken (knowingly) in revision 191712 > (https://codereview.chromium.org/12277011/). > > BUG=174194, 226909 > > Review URL: https://codereview.chromium.org/13811022 TBR=mmenke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195014

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -79 lines)			Patch
M	trunk/src/chrome/app/generated_resources.grd	View	2 chunks	+1 line, -7 lines	0 comments	Download
M	trunk/src/chrome/common/localized_error.h	View	1 chunk	+11 lines, -5 lines	0 comments	Download
M	trunk/src/chrome/common/localized_error.cc	View	7 chunks	+33 lines, -49 lines	0 comments	Download
M	trunk/src/chrome/renderer/chrome_content_renderer_client.cc	View	4 chunks	+12 lines, -9 lines	0 comments	Download
M	trunk/src/chrome/renderer/net/net_error_helper.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome/renderer/net/net_error_helper.cc	View	3 chunks	+3 lines, -8 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r195014.