New network error page: Fix resubmit warning page

New network error page:  Fix resubmit warning when
navigating forward / back to a page generated by a
POST that can not be retrieved from the CACHE.

This was broken (knowingly) in revision 191712
(https://codereview.chromium.org/12277011/).

BUG=174194, 226909
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194514

[Deprecated (see juliatuttle), 2013-04-09 19:23:14]

Looks good from a NetErrorHelper standpoint (although I will end up changing
when is_failed_post is saved in a future change).

[mmenke, 2013-04-09 19:30:56]

eroman:  This should be the last one of these for now (I hope...), other than
some minor string changes.

Thanks!

[mmenke, 2013-04-12 14:32:31]

On 2013/04/09 19:30:56, mmenke wrote:
> eroman:  This should be the last one of these for now (I hope...), other than
> some minor string changes.
> 
> Thanks!

Eric:  Just want to make sure this is on your radar (Know you were out for two
days).

[eroman, 2013-04-16 00:22:49]

lgtm

https://codereview.chromium.org/13811022/diff/24001/chrome/renderer/chrome_co...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/13811022/diff/24001/chrome/renderer/chrome_co...
chrome/renderer/chrome_content_renderer_client.cc:838: bool is_post =
EqualsASCII(failed_request.httpMethod(), "POST");
Is this guaranteed to be upper case?

[mmenke, 2013-04-16 14:46:18]

https://codereview.chromium.org/13811022/diff/24001/chrome/renderer/chrome_co...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/13811022/diff/24001/chrome/renderer/chrome_co...
chrome/renderer/chrome_content_renderer_client.cc:838: bool is_post =
EqualsASCII(failed_request.httpMethod(), "POST");
On 2013/04/16 00:22:49, eroman wrote:
> Is this guaranteed to be upper case?

Per RFC 2616, the method is actually case sensitive.  So if it's actually a
POST, either it violates spec, or it is guaranteed to be upper case.

[mmenke, 2013-04-16 14:55:09]

[+Nico]:  Please review chrome/renderer and chrome/common.

Thanks for all the reviews!

[Nico, 2013-04-16 21:49:14]

lgtm

https://codereview.chromium.org/13811022/diff/24001/chrome/common/localized_e...
File chrome/common/localized_error.cc (right):

https://codereview.chromium.org/13811022/diff/24001/chrome/common/localized_e...
chrome/common/localized_error.cc:551: // TODO(mmenke):  Fix this.
nit: Not clear to me what "this" means here.

https://codereview.chromium.org/13811022/diff/24001/chrome/common/localized_e...
chrome/common/localized_error.cc:702: return LookupErrorMap(error_domain,
error_code, false) != NULL;
nit: /*is_post=*/false

[mmenke, 2013-04-16 21:57:04]

Thanks for the feedback!

https://codereview.chromium.org/13811022/diff/24001/chrome/common/localized_e...
File chrome/common/localized_error.cc (right):

https://codereview.chromium.org/13811022/diff/24001/chrome/common/localized_e...
chrome/common/localized_error.cc:551: // TODO(mmenke):  Fix this.
On 2013/04/16 21:49:14, Nico wrote:
> nit: Not clear to me what "this" means here.

Fixed ("Make the reload button bring up the repost confirmation dialog for pages
resulting from posts").

https://codereview.chromium.org/13811022/diff/24001/chrome/common/localized_e...
chrome/common/localized_error.cc:702: return LookupErrorMap(error_domain,
error_code, false) != NULL;
On 2013/04/16 21:49:14, Nico wrote:
> nit: /*is_post=*/false

Done.

[mmenke, 2013-04-17 01:59:55]

Committed patchset #6 manually as r194514 (presubmit successful).