Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1436813009: Makes the default French keyboard as fr(oss) XKB layout. (Closed)

Created:
5 years, 1 month ago by Shu Chen
Modified:
5 years, 1 month ago
Reviewers:
Seigo Nonaka
CC:
chromium-reviews, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes the default French keyboard as fr(oss) XKB layout. BUG=409835 TEST=None TBR=nona@chromium.org Committed: https://crrev.com/47e24db9c43a449e2dc3f616b369685af7ecf098 Cr-Commit-Position: refs/heads/master@{#359495}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Shu Chen
TBR'ing nona@ as this is a trivial change and to catch up the M48 branch ...
5 years, 1 month ago (2015-11-13 04:51:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436813009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436813009/1
5 years, 1 month ago (2015-11-13 04:52:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 05:44:02 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/47e24db9c43a449e2dc3f616b369685af7ecf098 Cr-Commit-Position: refs/heads/master@{#359495}
5 years, 1 month ago (2015-11-13 05:44:41 UTC) #7
Shu Chen
5 years, 1 month ago (2015-11-13 12:34:44 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1444523004/ by shuchen@chromium.org.

The reason for reverting is: Suspect the cause of regression crbug.com/555507..

Powered by Google App Engine
This is Rietveld 408576698