Issue 1436813005: build: Move CFI Windows build config under OS=="win" block.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1436813005: build: Move CFI Windows build config under OS=="win" block. (Closed)

Created:
5 years, 1 month ago by pcc1

Modified:
5 years, 1 month ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

build: Move CFI Windows build config under OS=="win" block. Should unbreak CFI bots (update.sh does not support --print-clang-revision). BUG=464797 TBR=thakis@chromium.org Committed: https://crrev.com/373a674cd140140bfc31ec5ac49cb314902c3442 Cr-Commit-Position: refs/heads/master@{#359388}

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -9 lines)			Patch
	M	build/common.gypi	View		2 chunks	+17 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436813005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436813005/1

5 years, 1 month ago (2015-11-12 19:27:44 UTC) #2

commit-bot: I haz the power

5 years, 1 month ago (2015-11-12 21:17:36 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/373a674cd140140bfc31ec5ac49cb314902c3442
Cr-Commit-Position: refs/heads/master@{#359388}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages