Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: build/common.gypi

Issue 1436813005: build: Move CFI Windows build config under OS=="win" block. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index b80d0f232226fbc8b655f9427d779576d69f3c4e..18e6df207ff6c32fd98bb950cf66dcb612f0e1ae 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -6236,6 +6236,23 @@
'-fsanitize-blacklist=<(cfi_blacklist)',
],
},
+ }],
+ ['_toolset=="target" and _type!="static_library"', {
+ 'xcode_settings': {
+ 'OTHER_LDFLAGS': [
+ '-fsanitize=cfi-vcall',
+ '-fsanitize=cfi-derived-cast',
+ '-fsanitize=cfi-unrelated-cast',
+ ],
+ },
+ }],
+ ],
+ },
+ }],
+ ['cfi_vptr==1 and OS=="win"', {
+ 'target_defaults': {
+ 'target_conditions': [
+ ['_toolset=="target"', {
'msvs_settings': {
'VCCLCompilerTool': {
'AdditionalOptions': [
@@ -6261,15 +6278,6 @@
},
},
}],
- ['_toolset=="target" and _type!="static_library"', {
- 'xcode_settings': {
- 'OTHER_LDFLAGS': [
- '-fsanitize=cfi-vcall',
- '-fsanitize=cfi-derived-cast',
- '-fsanitize=cfi-unrelated-cast',
- ],
- },
- }],
],
},
}],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698