Oilpan: move NetworkResourcesData to the heap.

Oilpan: move NetworkResourcesData to the heap.

Do so in order to properly handle the Resource pointers that its
ResourceData keeps.

R=haraken
BUG=340522
Committed: https://crrev.com/2a53141e7508949a2d5427e851493bcb39a430b9
Cr-Commit-Position: refs/heads/master@{#359082}

[sof, 2015-11-11 10:07:25]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2015-11-11 10:07:26]

please take a look.

[haraken, 2015-11-11 10:11:27]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2015-11-11 10:11:27]

https://codereview.chromium.org/1436793002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp (right):

https://codereview.chromium.org/1436793002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp:161: clear();

It seems this destructor touches m_requestIdToResourceDataMap.

[sof, 2015-11-11 10:13:25]

https://codereview.chromium.org/1436793002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp (right):

https://codereview.chromium.org/1436793002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp:161: clear();
On 2015/11/11 10:11:27, haraken wrote:
> 
> It seems this destructor touches m_requestIdToResourceDataMap.

Quite right, didn't catch that in ps#1. No need to clear() here with Oilpan to
my mind - ps#2 makes it conditional on !ENABLE(OILPAN).

[haraken, 2015-11-11 10:32:01]

LGTM

[sof, 2015-11-11 10:42:31]

Description was changed from

==========
Oilpan: move NetworkResourcesData to the heap.

Do so in order to properly handle the Resource pointers that its
ResourceData keeps.

R=
BUG=340522
==========

to

==========
Oilpan: move NetworkResourcesData to the heap.

Do so in order to properly handle the Resource pointers that its
ResourceData keeps.

R=haraken
BUG=340522
==========

[sof, 2015-11-11 10:42:50]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2015-11-11 10:42:50]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1436793002/#ps60001
(title: "non-oilpan compile fix")

[commit-bot: I haz the power, 2015-11-11 10:43:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1436793002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1436793002/60001

[commit-bot: I haz the power, 2015-11-11 11:51:54]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-11-11 11:52:47]

Patchset 4 (id:??) landed as
https://crrev.com/2a53141e7508949a2d5427e851493bcb39a430b9
Cr-Commit-Position: refs/heads/master@{#359082}