third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp - Issue 1436793002: Oilpan: move NetworkResourcesData to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp

Issue 1436793002: Oilpan: move NetworkResourcesData to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: non-oilpan compile fix Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorResourceAgent.h ('k') | third_party/WebKit/Source/core/inspector/NetworkResourcesData.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp

index 651b6ce35eee51cbd9b74f6c3dfc653d6347a637..8a4228a319443f56019c17e6f4859e6697cc52ac 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp

@@ -411,6 +411,7 @@ InspectorResourceAgent::~InspectorResourceAgent()

DEFINE_TRACE(InspectorResourceAgent)

{

+ visitor->trace(m_resourcesData);

visitor->trace(m_replayXHRs);

visitor->trace(m_replayXHRsToBeDeleted);

visitor->trace(m_pendingXHRReplayData);

@@ -1091,7 +1092,7 @@ void InspectorResourceAgent::removeFinishedReplayXHRFired(Timer<InspectorResourc

InspectorResourceAgent::InspectorResourceAgent(InspectedFrames* inspectedFrames)

: InspectorBaseAgent<InspectorResourceAgent, InspectorFrontend::Network>("Network")

, m_inspectedFrames(inspectedFrames)

- , m_resourcesData(adoptPtr(new NetworkResourcesData()))

+ , m_resourcesData(NetworkResourcesData::create())

, m_pendingRequest(nullptr)

, m_isRecalculatingStyle(false)

, m_removeFinishedReplayXHRTimer(this, &InspectorResourceAgent::removeFinishedReplayXHRFired)