Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1436783002: Oilpan: tidy up AutoplayExperimentHelper. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, nessy, mlamouri+watch-blink_chromium.org, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews, vcarbune.chromium, philipj_slow
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: tidy up AutoplayExperimentHelper. Have this part object handle its HTMLMediaElement heap reference properly. R=haraken BUG=553613 Committed: https://crrev.com/177e526d4485af3ccc9b2a32e4a75be531120ecc Cr-Commit-Position: refs/heads/master@{#359076}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -27 lines) Patch
M third_party/WebKit/Source/core/html/AutoplayExperimentHelper.h View 4 chunks +11 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp View 13 chunks +27 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look.
5 years, 1 month ago (2015-11-11 09:06:39 UTC) #2
haraken
LGTM
5 years, 1 month ago (2015-11-11 09:30:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436783002/1
5 years, 1 month ago (2015-11-11 09:48:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-11 10:11:47 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 10:12:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/177e526d4485af3ccc9b2a32e4a75be531120ecc
Cr-Commit-Position: refs/heads/master@{#359076}

Powered by Google App Engine
This is Rietveld 408576698