Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 14367030: Remove GR_STATIC_RECT_VB (take 2) (Closed)

Created:
7 years, 8 months ago by robertphillips
Modified:
7 years, 8 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

This was initially attempted in r7625 - https://codereview.appspot.com/7304055) and rolled into Chrome at r181299. It was reverted in r7683 due to some mixed performance results on the Chrome perfbots (rolled into Chrome at r181688). A new Pixel bug (https://code.google.com/p/chromium/issues/detail?id=180345) has revived interest in removing it.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -127 lines) Patch
M include/gpu/GrConfig.h View 1 chunk +0 lines, -9 lines 0 comments Download
M include/gpu/GrUserConfig.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/gpu/GrContext.cpp View 2 chunks +1 line, -63 lines 0 comments Download
M src/gpu/GrGpu.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/gpu/GrGpu.cpp View 4 chunks +0 lines, -38 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
robertphillips
7 years, 8 months ago (2013-04-19 18:56:46 UTC) #1
bsalomon
lgtm
7 years, 8 months ago (2013-04-19 19:02:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/14367030/1
7 years, 8 months ago (2013-04-20 10:57:00 UTC) #3
robertphillips
7 years, 8 months ago (2013-04-20 12:10:51 UTC) #4
Message was sent while issue was closed.
committed as r8786

Powered by Google App Engine
This is Rietveld 408576698