Rename ClampToMin and ClampToMax

Rename ClampToMin and ClampToMax

I find these function names confusing. I have to stop and read the code each
time I try to use them to figure out what they're going to do.

Part of the confusion is that ClampToMin sets the components to the _maximum_
of the two sizes/vectors. It's also not clear from the function name which of
the two objects is acting as the 'Min'. This is mitigated by the parameter names
and local variables passed to the function, but it would be nice if the name
of the function itself made this clear.

a.ClampToLowerBound(b) makes it clear both that b is acting as the lower bound
and how and when a is going to be altered.

Other names I've considered (for ClampToMin -- the suggestions for ClampToMax
are analagous):
  ClampIfSmallerThan(other)
  SetComponentsToMax(other)
  Union(other) (for sizes)

R=danakj,sky
BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203017

[danakj, 2013-04-19 15:59:40]

I like the names. LGTM if it does to sky@.

[sky, 2013-04-22 16:44:18]

https://codereview.chromium.org/14367021/diff/2001/ui/gfx/point_base.h
File ui/gfx/point_base.h (right):

https://codereview.chromium.org/14367021/diff/2001/ui/gfx/point_base.h#newcode46
ui/gfx/point_base.h:46: void ClampToUpperBound(const Class& max) {
I agree the names are confusing, but I'm not sure I like this one better. It's
still confusing. Seems like this should be named SetToMin and the other
SetToMax. The argument should be renamed too.

[danakj, 2013-05-25 13:26:25]

Do you still plan to go ahead with this Cl or should we close it?

[Ian Vollick, 2013-05-27 13:54:02]

On 2013/05/25 13:26:25, danakj wrote:
> Do you still plan to go ahead with this Cl or should we close it?

I'd still like to go ahead with it.

sky@ I've uploaded a CL with the names you've suggested. I've got a slight bias
towards ClampToLowerBound over SetToMax because, IMO, it's more obvious that the
operation is per-component, but I like your suggestion, too.

[sky, 2013-05-28 14:30:32]

LGTM

[commit-bot: I haz the power, 2013-05-28 15:02:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vollick@chromium.org/14367021/12001

[commit-bot: I haz the power, 2013-05-28 15:25:03]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-05-28 18:25:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vollick@chromium.org/14367021/33001

[commit-bot: I haz the power, 2013-05-28 18:46:32]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-05-29 01:12:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vollick@chromium.org/14367021/33001

[commit-bot: I haz the power, 2013-05-29 01:38:45]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-05-29 20:23:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vollick@chromium.org/14367021/52001

[commit-bot: I haz the power, 2013-05-30 00:18:01]

Change committed as 203017