Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 14367020: Revert r14252 as it broke --prof for some cases (Closed)

Created:
7 years, 8 months ago by yurys
Modified:
7 years, 8 months ago
Reviewers:
loislo, alph, Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Revert r14252 as it broke --prof for some cases R=jkummerow BUG=v8:2642 Committed: https://code.google.com/p/v8/source/detail?r=14348

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -29 lines) Patch
M src/log.cc View 1 chunk +7 lines, -1 line 0 comments Download
M src/profile-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/sampler.h View 1 chunk +7 lines, -2 lines 0 comments Download
M src/sampler.cc View 1 chunk +10 lines, -1 line 0 comments Download
M test/cctest/test-cpu-profiler.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M test/cctest/test-log-stack-tracer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-profile-generator.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M test/mjsunit/tools/tickprocessor-test.log View 1 chunk +13 lines, -13 lines 0 comments Download
M test/mjsunit/tools/tickprocessor-test-func-info.log View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/tickprocessor.js View 3 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
7 years, 8 months ago (2013-04-19 11:31:18 UTC) #1
Jakob Kummerow
LGTM. Thanks!
7 years, 8 months ago (2013-04-19 11:53:24 UTC) #2
yurys
7 years, 8 months ago (2013-04-19 11:55:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14348 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698