src/profile-generator.cc - Issue 14367020: Revert r14252 as it broke --prof for some cases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/profile-generator.cc

Issue 14367020: Revert r14252 as it broke --prof for some cases (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/profile-generator.cc

diff --git a/src/profile-generator.cc b/src/profile-generator.cc

index eacabeff4f1ab8c882b10c038052d2335d973759..e4c750cb83c1dbc8b489f2a08779d3b43ccacb0d 100644

--- a/src/profile-generator.cc

+++ b/src/profile-generator.cc

@@ -894,7 +894,7 @@ void ProfileGenerator::RecordTickSample(const TickSample& sample) {

if (sample.pc != NULL) {

*entry++ = code_map_.FindEntry(sample.pc);

- if (sample.external_callback) {

+ if (sample.has_external_callback) {

// Don't use PC when in external callback code, as it can point

// inside callback's code, and we will erroneously report

// that a callback calls itself.

« no previous file with comments | « src/log.cc ('k') | src/sampler.h » ('j') | no next file with comments »