Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: third_party/WebKit/Source/core/page/PageSerializer.h

Issue 1436683002: Making PageSerializer operate on single frames only. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mhtml-removing-unused-code
Patch Set: Addressed 2nd round of CR feedback from Daniel. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/page/PageSerializer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/page/PageSerializer.h
diff --git a/third_party/WebKit/Source/core/page/PageSerializer.h b/third_party/WebKit/Source/core/page/PageSerializer.h
index 501d99f509edbf3c654d92bea6453d31d2bd7b70..eb1cdaea516cfd51879388123fc2be374634fd7f 100644
--- a/third_party/WebKit/Source/core/page/PageSerializer.h
+++ b/third_party/WebKit/Source/core/page/PageSerializer.h
@@ -58,8 +58,9 @@ class StylePropertySet;
struct SerializedResource;
-// This class is used to serialize a page contents back to text (typically HTML).
-// It serializes all the page frames and retrieves resources such as images and CSS stylesheets.
+// This class is used to serialize frame's contents back to text (typically HTML).
+// It serializes frame's document and resources such as images and CSS stylesheets.
+// TODO(lukasza): Rename this class to FrameSerializer.
class CORE_EXPORT PageSerializer final {
STACK_ALLOCATED();
public:
@@ -72,10 +73,11 @@ public:
PageSerializer(Vector<SerializedResource>*, PassOwnPtr<Delegate>);
- // Initiates the serialization of the frame's page. All serialized content and retrieved
- // resources are added to the Vector passed to the constructor. The first resource in that
- // vector is the top frame serialized content.
- void serialize(Page*);
+ // Initiates the serialization of the frame. All serialized content and
+ // retrieved resources are added to the Vector passed to the constructor.
+ // The first resource in that vector is the frame's serialized content.
+ // Subsequent resources are images, css, etc.
+ void serializeFrame(LocalFrame&);
tkent 2015/11/18 22:32:55 nit: Can we change |LocalFrame&| to |const LocalFr
Łukasz Anforowicz 2015/11/18 23:27:41 Done (constness cascaded into urlForBlankFrame and
void registerRewriteURL(const String& from, const String& to);
void setRewriteURLFolder(const String&);
@@ -87,8 +89,6 @@ public:
static String markOfTheWebDeclaration(const KURL&);
private:
- void serializeFrame(LocalFrame*);
-
// Serializes the stylesheet back to text and adds it to the resources if URL is not-empty.
// It also adds any resources included in that stylesheet (including any imported stylesheets and their own resources).
void serializeCSSStyleSheet(CSSStyleSheet&, const KURL&);
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/page/PageSerializer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698