Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Unified Diff: third_party/WebKit/Source/core/page/PageSerializer.cpp

Issue 1436683002: Making PageSerializer operate on single frames only. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mhtml-removing-unused-code
Patch Set: Addressed 2nd round of CR feedback from Daniel. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/PageSerializer.cpp
diff --git a/third_party/WebKit/Source/core/page/PageSerializer.cpp b/third_party/WebKit/Source/core/page/PageSerializer.cpp
index 28ac4e0564ee129c437ae60281354dd5e06b5697..d5560ec32cd6e318b9c3d5831cb68c8567a7af78 100644
--- a/third_party/WebKit/Source/core/page/PageSerializer.cpp
+++ b/third_party/WebKit/Source/core/page/PageSerializer.cpp
@@ -304,20 +304,15 @@ PageSerializer::PageSerializer(Vector<SerializedResource>* resources, PassOwnPtr
{
}
-void PageSerializer::serialize(Page* page)
+void PageSerializer::serializeFrame(LocalFrame& frame)
{
- serializeFrame(page->deprecatedLocalMainFrame());
-}
-
-void PageSerializer::serializeFrame(LocalFrame* frame)
-{
- ASSERT(frame->document());
- Document& document = *frame->document();
+ ASSERT(frame.document());
+ Document& document = *frame.document();
KURL url = document.url();
// FIXME: This probably wants isAboutBlankURL? to exclude other about: urls (like about:srcdoc)?
if (!url.isValid() || url.protocolIsAbout()) {
// For blank frames we generate a fake URL so they can be referenced by their containing frame.
- url = urlForBlankFrame(frame);
+ url = urlForBlankFrame(&frame);
}
if (m_resourceURLs.contains(url)) {
@@ -385,13 +380,6 @@ void PageSerializer::serializeFrame(LocalFrame* frame)
serializeCSSStyleSheet(*sheet, KURL());
}
}
-
- for (Frame* childFrame = frame->tree().firstChild(); childFrame; childFrame = childFrame->tree().nextSibling()) {
- // TODO(lukasza): This causes incomplete MHTML for OOPIFs.
- // (crbug.com/538766)
- if (childFrame->isLocalFrame())
- serializeFrame(toLocalFrame(childFrame));
- }
}
void PageSerializer::serializeCSSStyleSheet(CSSStyleSheet& styleSheet, const KURL& url)

Powered by Google App Engine
This is Rietveld 408576698