Issue 1436673003: Merge to XFA: Prevent buffer underflow in CPDF_TextObject::CalcPositionData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1436673003: Merge to XFA: Prevent buffer underflow in CPDF_TextObject::CalcPositionData (Closed)

Created:
5 years, 1 month ago by Oliver Chang

Modified:
5 years, 1 month ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Prevent buffer underflow in CPDF_TextObject::CalcPositionData R=tsepez@chromium.org TBR=tsepez@chromium.org BUG=554115 Review URL: https://codereview.chromium.org/1435473004 . (cherry picked from commit 46d2e278f62454ed2392630b6d18d33d380a20eb) Committed: https://pdfium.googlesource.com/pdfium/+/07cafd7e570920810b1589ca30db0a7057b9b6ac

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	core/src/fpdfapi/fpdf_page/fpdf_page.cpp	View		1 chunk	+5 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Oliver Chang

.. you're too quick Tom, was about to send "TBR. merge clean."

5 years, 1 month ago (2015-11-10 22:16:52 UTC) #2

Oliver Chang

5 years, 1 month ago (2015-11-10 22:17:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
07cafd7e570920810b1589ca30db0a7057b9b6ac (presubmit successful).