Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1435473004: Prevent buffer underflow in CPDF_TextObject::CalcPositionData (Closed)

Created:
5 years, 1 month ago by Oliver Chang
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Prevent buffer underflow in CPDF_TextObject::CalcPositionData R=tsepez@chromium.org BUG=554115 Committed: https://pdfium.googlesource.com/pdfium/+/46d2e278f62454ed2392630b6d18d33d380a20eb

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M core/src/fpdfapi/fpdf_page/fpdf_page.cpp View 1 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Oliver Chang
ptal
5 years, 1 month ago (2015-11-10 21:52:39 UTC) #2
Tom Sepez
https://codereview.chromium.org/1435473004/diff/1/core/src/fpdfapi/fpdf_page/fpdf_page.cpp File core/src/fpdfapi/fpdf_page/fpdf_page.cpp (right): https://codereview.chromium.org/1435473004/diff/1/core/src/fpdfapi/fpdf_page/fpdf_page.cpp#newcode412 core/src/fpdfapi/fpdf_page/fpdf_page.cpp:412: if (charcode == (FX_DWORD)-1 && i > 0) { ...
5 years, 1 month ago (2015-11-10 22:03:16 UTC) #3
Oliver Chang
https://codereview.chromium.org/1435473004/diff/1/core/src/fpdfapi/fpdf_page/fpdf_page.cpp File core/src/fpdfapi/fpdf_page/fpdf_page.cpp (right): https://codereview.chromium.org/1435473004/diff/1/core/src/fpdfapi/fpdf_page/fpdf_page.cpp#newcode412 core/src/fpdfapi/fpdf_page/fpdf_page.cpp:412: if (charcode == (FX_DWORD)-1 && i > 0) { ...
5 years, 1 month ago (2015-11-10 22:07:54 UTC) #4
Tom Sepez
lgtm
5 years, 1 month ago (2015-11-10 22:11:02 UTC) #5
Oliver Chang
5 years, 1 month ago (2015-11-10 22:11:59 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
46d2e278f62454ed2392630b6d18d33d380a20eb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698