Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: mojo/devtools/common/devtoolslib/linux_shell.py

Issue 1436503002: devtools: new workflow for multiple simultaneous `mojo_run` runs. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Address Ben's comments. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/devtools/common/devtoolslib/android_shell.py ('k') | mojo/devtools/common/devtoolslib/shell.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/devtools/common/devtoolslib/linux_shell.py
diff --git a/mojo/devtools/common/devtoolslib/linux_shell.py b/mojo/devtools/common/devtoolslib/linux_shell.py
index 48a28592cd8e3c38bf507f67ec5eea6c90c944a4..8a0ec7f28d72259b1c09a9c82d5dfff5a71fd4e8 100644
--- a/mojo/devtools/common/devtoolslib/linux_shell.py
+++ b/mojo/devtools/common/devtoolslib/linux_shell.py
@@ -25,8 +25,14 @@ class LinuxShell(Shell):
self.command_prefix = command_prefix if command_prefix else []
@overrides(Shell)
- def serve_local_directories(self, mappings, port=0, free_host_port=False):
- return 'http://%s:%d/' % http_server.start_http_server(mappings, port)
+ def serve_local_directories(self, mappings, port=0, reuse_servers=False):
+ if reuse_servers:
+ assert port, 'Cannot reuse the server when |port| is 0.'
+ server_address = ('127.0.0.1', port)
+ else:
+ server_address = http_server.start_http_server(mappings, port)
+
+ return 'http://%s:%d/' % server_address
@overrides(Shell)
def forward_host_port_to_shell(self, host_port):
« no previous file with comments | « mojo/devtools/common/devtoolslib/android_shell.py ('k') | mojo/devtools/common/devtoolslib/shell.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698