Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Unified Diff: mojo/devtools/common/devtoolslib/shell.py

Issue 1436503002: devtools: new workflow for multiple simultaneous `mojo_run` runs. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Address Ben's comments. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/devtools/common/devtoolslib/shell.py
diff --git a/mojo/devtools/common/devtoolslib/shell.py b/mojo/devtools/common/devtoolslib/shell.py
index 7e1d395cf6f7ffaba83ad4a928c14ef05f5438e8..bc478565e41d9798a31f6156a0e737fc3e066518 100644
--- a/mojo/devtools/common/devtoolslib/shell.py
+++ b/mojo/devtools/common/devtoolslib/shell.py
@@ -6,7 +6,7 @@
class Shell(object):
"""Represents an abstract Mojo shell."""
- def serve_local_directories(self, mappings, port=0, free_host_port=False):
+ def serve_local_directories(self, mappings, port=0, reuse_servers=False):
"""Serves the content of the local (host) directories, making it available
to the shell under the url returned by the function.
@@ -22,9 +22,9 @@ class Shell(object):
port: port at which the server will be available to the shell. On Android
this can be different from the port on which the server runs on the
host.
- free_host_port: spawn the server a system allocated port. This is ignored
- on Linux, where |port| indicates the port on which the server will be
- spawned.
+ reuse_servers: don't actually spawn the server. Instead assume that the
+ server is already running on |port|, and only set up forwarding if
+ needed.
Returns:
The url that the shell can use to access the server.
« no previous file with comments | « mojo/devtools/common/devtoolslib/linux_shell.py ('k') | mojo/devtools/common/devtoolslib/shell_arguments.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698