Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 1436503002: devtools: new workflow for multiple simultaneous `mojo_run` runs. (Closed)

Created:
5 years, 1 month ago by ppi
Modified:
5 years, 1 month ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

devtools: new workflow for multiple simultaneous `mojo_run` runs. This patch provides a new workflow for multiple simultaneous runs of `mojo_run`. In the new workflow first instance of `mojo_run` is started normally, while the subsequent ones get the `--reuse-servers` flag. `--reuse-servers` skips spawning any dev servers, instead it assumes that they are already running and only sets up port forwarding if needed. This preserves caching and should work over adb_remote_setup. The previous workaround switches: `--free-ports` and `--free-host-ports` are removed. Fixes https://github.com/domokit/devtools/issues/55 . R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b80202520e08230ac7c114569ffc0840581b4e0c

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Address Ben's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -63 lines) Patch
M mojo/devtools/common/devtoolslib/android_shell.py View 1 2 2 chunks +7 lines, -4 lines 0 comments Download
M mojo/devtools/common/devtoolslib/linux_shell.py View 1 2 1 chunk +8 lines, -2 lines 0 comments Download
M mojo/devtools/common/devtoolslib/shell.py View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/devtools/common/devtoolslib/shell_arguments.py View 9 chunks +23 lines, -30 lines 0 comments Download
M mojo/devtools/common/devtoolslib/shell_config.py View 6 chunks +6 lines, -13 lines 0 comments Download
M mojo/devtools/common/docs/mojo_run.md View 1 chunk +33 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ppi
Hi Ben, ptal.
5 years, 1 month ago (2015-11-09 14:34:17 UTC) #1
ppi
Added asserts as discussed offline, ptal.
5 years, 1 month ago (2015-11-09 16:11:28 UTC) #2
qsr
lgtm
5 years, 1 month ago (2015-11-09 16:17:22 UTC) #3
ppi
5 years, 1 month ago (2015-11-09 16:18:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
b80202520e08230ac7c114569ffc0840581b4e0c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698