Send safe browsing ThreatDetails to track download CTR when user tries to recover blocked downloads

chrome/browser/download/download_danger_prompt.h

Index: chrome/browser/download/download_danger_prompt.h
diff --git a/chrome/browser/download/download_danger_prompt.h b/chrome/browser/download/download_danger_prompt.h
index e1b5c612c08994378a2e598440e948009d6aef82..e8a086930a909d5e097b41db608f18326ec2fe12 100644
--- a/chrome/browser/download/download_danger_prompt.h
+++ b/chrome/browser/download/download_danger_prompt.h
@@ -6,6 +6,7 @@
 #define CHROME_BROWSER_DOWNLOAD_DOWNLOAD_DANGER_PROMPT_H_
 
 #include "base/callback_forward.h"
+#include "url/gurl.h"

[Lei Zhang, 2015/11/24 18:55:27]

forward decl GURL instead?

[Jialiu Lin, 2015/11/25 23:43:21]

Done.

 
 namespace content {
 class DownloadItem;
@@ -37,15 +38,22 @@ class DownloadDangerPrompt {
   // caller does not own the object and receive no guarantees about lifetime.
   // If |show_context|, then the prompt message will contain some information
   // about the download and its danger; otherwise it won't.
-  static DownloadDangerPrompt* Create(
-      content::DownloadItem* item,
-      content::WebContents* web_contents,
-      bool show_context,
-      const OnDone& done);
+  static DownloadDangerPrompt* Create(content::DownloadItem* item,
+                                      content::WebContents* web_contents,
+                                      bool show_context,
+                                      const OnDone& done);
 
   // Only to be used by tests. Subclasses must override to manually call the
   // respective button click handler.
   virtual void InvokeActionForTesting(Action action) = 0;
+
+ protected:
+  // Sends download recovery report to safe browsing backend.
+  // Since it only records download url (DownloadItem::GetURL()) and user's
+  // action (click through or not), it isn't gated by extended_reporting. We

[Lei Zhang, 2015/11/24 18:55:27]

What does "extended_reporting" refer to here?

[Jialiu Lin, 2015/11/25 23:43:21]

This refers to prefs::kSafeBrowsingExtendedReportingEnabled.
Updated this comment to make it clearer. 

+  // should not put any extra information in this report.
+  static void SendSafeBrowsingDownloadRecoveryReport(bool did_proceed,
+                                                     const GURL& url);
 };
 
 #endif  // CHROME_BROWSER_DOWNLOAD_DOWNLOAD_DANGER_PROMPT_H_