Send safe browsing ThreatDetails to track download CTR when user tries to recover blocked downloads

chrome/browser/download/download_danger_prompt.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_DOWNLOAD_DOWNLOAD_DANGER_PROMPT_H_
 #define CHROME_BROWSER_DOWNLOAD_DOWNLOAD_DANGER_PROMPT_H_
 
 #include "base/callback_forward.h"
+#include "url/gurl.h"

[Lei Zhang, 2015/11/24 18:55:27]

forward decl GURL instead?

[Jialiu Lin, 2015/11/25 23:43:21]

Done.

 
 namespace content {
 class DownloadItem;
 class WebContents;
 }
 
 // Prompts the user for whether to Keep a dangerous DownloadItem using native
 // UI. This prompt is invoked by the DownloadsDOMHandler when the user wants to
 // accept a dangerous download. Having a native dialog intervene during the this
 // workflow means that the chrome://downloads page no longer has the privilege
@@ skipping 11 matching lines @@
   typedef base::Callback<void(Action)> OnDone;
 
   // Return a new self-deleting DownloadDangerPrompt. |accepted| or |canceled|
   // will be run when the the respective action is invoked. |canceled| may also
   // be called when |item| is either no longer dangerous or no longer in
   // progress, or if the tab corresponding to |web_contents| is
   // closing. The returned DownloadDangerPrompt* is only used for testing. The
   // caller does not own the object and receive no guarantees about lifetime.
   // If |show_context|, then the prompt message will contain some information
   // about the download and its danger; otherwise it won't.
-  static DownloadDangerPrompt* Create(
-      content::DownloadItem* item,
-      content::WebContents* web_contents,
-      bool show_context,
-      const OnDone& done);
+  static DownloadDangerPrompt* Create(content::DownloadItem* item,
+                                      content::WebContents* web_contents,
+                                      bool show_context,
+                                      const OnDone& done);
 
   // Only to be used by tests. Subclasses must override to manually call the
   // respective button click handler.
   virtual void InvokeActionForTesting(Action action) = 0;
+
+ protected:
+  // Sends download recovery report to safe browsing backend.
+  // Since it only records download url (DownloadItem::GetURL()) and user's
+  // action (click through or not), it isn't gated by extended_reporting. We

[Lei Zhang, 2015/11/24 18:55:27]

What does "extended_reporting" refer to here?

[Jialiu Lin, 2015/11/25 23:43:21]

This refers to prefs::kSafeBrowsingExtendedReportingEnabled.
Updated this comment to make it clearer. 

+  // should not put any extra information in this report.
+  static void SendSafeBrowsingDownloadRecoveryReport(bool did_proceed,
+                                                     const GURL& url);
 };
 
 #endif  // CHROME_BROWSER_DOWNLOAD_DOWNLOAD_DANGER_PROMPT_H_