Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14362031: Move part of WizardController static code to StartupUtils (Closed)

Created:
7 years, 8 months ago by Denis Kuznetsov (DE-MUC)
Modified:
7 years, 8 months ago
CC:
chromium-reviews, dtseng+watch_chromium.org, Ilya Sherman, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, kkania, MAD, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, Aaron Boodman, robertshield, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, ctguil+watch_chromium.org, stevenjb+watch_chromium.org, jar (doing other things), davemoore+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

Move part of WizardController static code to StartupUtils BUG=231331 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195202

Patch Set 1 #

Total comments: 9

Patch Set 2 : Fix nit #

Patch Set 3 : Add comments #

Patch Set 4 : Fix 80-symbols problem #

Patch Set 5 : Fighting with whitespaces again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -183 lines) Patch
M chrome/browser/automation/testing_automation_provider_chromeos.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/background/ash_user_wallpaper_delegate.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/info_private_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/enterprise_enrollment_screen.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/login_display_host_impl.cc View 6 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen.cc View 2 chunks +2 lines, -1 line 0 comments Download
A chrome/browser/chromeos/login/startup_utils.h View 1 2 3 4 1 chunk +48 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/startup_utils.cc View 1 chunk +169 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/webui_login_display_host.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 1 chunk +0 lines, -27 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 8 chunks +7 lines, -114 lines 0 comments Download
M chrome/browser/chromeos/mobile_config.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/options/wimax_config_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/system/tray_accessibility_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/variations/eula_accepted_notifier_chromeos.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/help/version_updater_chromeos.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 3 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Denis Kuznetsov (DE-MUC)
Just moving code around, no functional changes.
7 years, 8 months ago (2013-04-19 14:25:18 UTC) #1
Nikita (slow)
lgtm https://codereview.chromium.org/14362031/diff/1/chrome/browser/automation/testing_automation_provider_chromeos.cc File chrome/browser/automation/testing_automation_provider_chromeos.cc (right): https://codereview.chromium.org/14362031/diff/1/chrome/browser/automation/testing_automation_provider_chromeos.cc#newcode231 chrome/browser/automation/testing_automation_provider_chromeos.cc:231: WizardController* wizard_controller = WizardController::default_controller(); nit: Move below. https://codereview.chromium.org/14362031/diff/1/chrome/browser/automation/testing_automation_provider_chromeos.cc#newcode232 ...
7 years, 8 months ago (2013-04-19 14:37:56 UTC) #2
Denis Kuznetsov (DE-MUC)
https://codereview.chromium.org/14362031/diff/1/chrome/browser/automation/testing_automation_provider_chromeos.cc File chrome/browser/automation/testing_automation_provider_chromeos.cc (right): https://codereview.chromium.org/14362031/diff/1/chrome/browser/automation/testing_automation_provider_chromeos.cc#newcode231 chrome/browser/automation/testing_automation_provider_chromeos.cc:231: WizardController* wizard_controller = WizardController::default_controller(); On 2013/04/19 14:37:56, Nikita Kostylev ...
7 years, 8 months ago (2013-04-19 14:49:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/14362031/6001
7 years, 8 months ago (2013-04-19 14:49:22 UTC) #4
commit-bot: I haz the power
Presubmit check for 14362031-6001 failed and returned exit status 1. INFO:root:Found 22 file(s). Running presubmit ...
7 years, 8 months ago (2013-04-19 14:49:39 UTC) #5
Denis Kuznetsov (DE-MUC)
Committed patchset #5 manually as r195202.
7 years, 8 months ago (2013-04-19 15:10:03 UTC) #6
Ben Goodger (Google)
7 years, 8 months ago (2013-04-19 16:15:21 UTC) #7
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698