Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14362028: Speculative Revert 195108 "Changes to closing contents with beforeunload/unl..." (Closed)

Created:
7 years, 8 months ago by Nikita (slow)
Modified:
7 years, 8 months ago
Reviewers:
slamm
CC:
chromium-reviews
Visibility:
Public.

Description

Speculative Revert 195108 "Changes to closing contents with beforeunload/unl..." http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.6%20Tests%20%28dbg%29%282%29&number=37441 http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.6%20Tests%20%281%29&number=38872 http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.6%20Tests%20%282%29&number=35827 http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.6%20Tests%20%283%29&number=33187 > Changes to closing contents with beforeunload/unload handlers: > - Closing a single tab, run beforeunload (if needed), then detached the tab from > tab strip and close it asynchronously (no ui). > - Closing a window, run all beforeunload handlers (same as before), then detach all tabs with unload handlers. Close any remaining tabs and hide the browser window while waiting for the unload handlers to complete. > > This CL started with fast-tab-closure and has grown to include fast-window-closure too. > > BUG=142458, 156896 > > Review URL: https://chromiumcodereview.appspot.com/11016023 TBR=slamm@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195134

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -487 lines) Patch
M trunk/src/chrome/browser/ui/browser.h View 2 chunks +3 lines, -10 lines 0 comments Download
M trunk/src/chrome/browser/ui/browser.cc View 3 chunks +5 lines, -12 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +3 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/ui/gtk/browser_window_gtk.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/ui/unload_controller.h View 7 chunks +6 lines, -39 lines 0 comments Download
M trunk/src/chrome/browser/ui/unload_controller.cc View 4 chunks +36 lines, -119 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/unload_browsertest.cc View 1 chunk +0 lines, -187 lines 0 comments Download
D trunk/src/chrome/test/data/fast_tab_close/no_listeners.html View 1 chunk +0 lines, -11 lines 0 comments Download
D trunk/src/chrome/test/data/fast_tab_close/unload_sets_cookie.html View 1 chunk +0 lines, -18 lines 0 comments Download
D trunk/src/chrome/test/data/fast_tab_close/unload_sleep_before_cookie.html View 1 chunk +0 lines, -28 lines 0 comments Download
M trunk/src/content/browser/web_contents/web_contents_impl.h View 2 chunks +0 lines, -6 lines 0 comments Download
M trunk/src/content/browser/web_contents/web_contents_impl.cc View 3 chunks +5 lines, -24 lines 0 comments Download
M trunk/src/content/public/browser/web_contents.h View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nikita (slow)
7 years, 8 months ago (2013-04-19 12:12:23 UTC) #1
Nikita (slow)
Committed patchset #1 manually as r195134.
7 years, 8 months ago (2013-04-19 12:12:42 UTC) #2
slamm
7 years, 8 months ago (2013-04-19 16:29:38 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698