trunk/src/content/browser/web_contents/web_contents_impl.h - Issue 14362028: Speculative Revert 195108 "Changes to closing contents with beforeunload/unl..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/src/content/browser/web_contents/web_contents_impl.h

Issue 14362028: Speculative Revert 195108 "Changes to closing contents with beforeunload/unl..." (Closed) Base URL: svn://svn.chromium.org/chrome/

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « trunk/src/chrome/test/data/fast_tab_close/unload_sleep_before_cookie.html ('k') | trunk/src/content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: trunk/src/content/browser/web_contents/web_contents_impl.h

===================================================================

--- trunk/src/content/browser/web_contents/web_contents_impl.h (revision 195133)

+++ trunk/src/content/browser/web_contents/web_contents_impl.h (working copy)

@@ -245,9 +245,6 @@

virtual base::TimeTicks GetNewTabStartTime() const OVERRIDE;

virtual void Close() OVERRIDE;

virtual void OnCloseStarted() OVERRIDE;

- virtual void OnCloseCanceled() OVERRIDE;

- virtual void OnUnloadStarted() OVERRIDE;

- virtual void OnUnloadDetachedStarted() OVERRIDE;

virtual void SystemDragEnded() OVERRIDE;

virtual void UserGestureDone() OVERRIDE;

virtual void SetClosedByUserGesture(bool value) OVERRIDE;

@@ -821,9 +818,6 @@

// The time when onbeforeunload ended.

base::TimeTicks before_unload_end_time_;

- // The time when the tab was removed from view during close.

- base::TimeTicks unload_detached_start_time_;

// The time that this tab was last selected.

base::TimeTicks last_selected_time_;