Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1436163003: Mark WebappSplashScreenIconTest#testShowSplashIcon as flaky (Closed)

Created:
5 years, 1 month ago by dgn
Modified:
5 years, 1 month ago
Reviewers:
gone
CC:
chromium-reviews, mlamouri (slow - plz ping)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark WebappSplashScreenIconTest#testShowSplashIcon as flaky Added in https://codereview.chromium.org/1414873004 TBR=dfalcantara@chromium.org BUG=554929 Committed: https://crrev.com/567ee4cbb84855641304da750f4865b95eb18054 Cr-Commit-Position: refs/heads/master@{#359304}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenIconTest.java View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436163003/1
5 years, 1 month ago (2015-11-12 11:53:42 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 12:20:11 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/567ee4cbb84855641304da750f4865b95eb18054 Cr-Commit-Position: refs/heads/master@{#359304}
5 years, 1 month ago (2015-11-12 20:06:43 UTC) #5
mlamouri (slow - plz ping)
5 years, 1 month ago (2015-11-19 19:01:42 UTC) #6
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1453243005/ by mlamouri@chromium.org.

The reason for reverting is: dfalcantara@ fixed a larger issue with web apps
tests on N4 devices. Reverting this in case of his CL fixed the problem..

Powered by Google App Engine
This is Rietveld 408576698