Oilpan: tidier ContentSecurityPolicy back refs from auxillary CSP objects.

Oilpan: tidier ContentSecurityPolicy back refs from auxillary CSP objects.

R=haraken
BUG=553613
Committed: https://crrev.com/b574c130b6a74c98e45e4331a04c02324c1770d2
Cr-Commit-Position: refs/heads/master@{#359831}

[sof, 2015-11-12 10:25:07]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[haraken, 2015-11-12 10:37:22]

Would it be hard to move those objects to the heap? UntracedMembers should be
avoided as much as possible.

[sof, 2015-11-16 11:39:37]

On 2015/11/12 10:37:22, haraken wrote:
> Would it be hard to move those objects to the heap? UntracedMembers should be
> avoided as much as possible.

Not hard, but yet more work (and not-too-interesting objects on the heap.)

[haraken, 2015-11-16 11:40:53]

On 2015/11/16 11:39:37, sof wrote:
> On 2015/11/12 10:37:22, haraken wrote:
> > Would it be hard to move those objects to the heap? UntracedMembers should
be
> > avoided as much as possible.
> 
> Not hard, but yet more work (and not-too-interesting objects on the heap.)

okay, then WeakPersistent?

[sof, 2015-11-16 11:42:42]

On 2015/11/16 11:40:53, haraken wrote:
> On 2015/11/16 11:39:37, sof wrote:
> > On 2015/11/12 10:37:22, haraken wrote:
> > > Would it be hard to move those objects to the heap? UntracedMembers should
> be
> > > avoided as much as possible.
> > 
> > Not hard, but yet more work (and not-too-interesting objects on the heap.)
> 
> okay, then WeakPersistent?

Excessive to use WeakPersistent<>, imo.

[haraken, 2015-11-16 11:43:35]

On 2015/11/16 11:42:42, sof wrote:
> On 2015/11/16 11:40:53, haraken wrote:
> > On 2015/11/16 11:39:37, sof wrote:
> > > On 2015/11/12 10:37:22, haraken wrote:
> > > > Would it be hard to move those objects to the heap? UntracedMembers
should
> > be
> > > > avoided as much as possible.
> > > 
> > > Not hard, but yet more work (and not-too-interesting objects on the heap.)
> > 
> > okay, then WeakPersistent?
> 
> Excessive to use WeakPersistent<>, imo.

Fair enough. LGTM.

[sof, 2015-11-16 11:50:53]

On 2015/11/16 11:43:35, haraken wrote:
> On 2015/11/16 11:42:42, sof wrote:
> > On 2015/11/16 11:40:53, haraken wrote:
> > > On 2015/11/16 11:39:37, sof wrote:
> > > > On 2015/11/12 10:37:22, haraken wrote:
> > > > > Would it be hard to move those objects to the heap? UntracedMembers
> should
> > > be
> > > > > avoided as much as possible.
> > > > 
> > > > Not hard, but yet more work (and not-too-interesting objects on the
heap.)
> > > 
> > > okay, then WeakPersistent?
> > 
> > Excessive to use WeakPersistent<>, imo.
> 
> Fair enough. LGTM.

Add TODOs next to them.

[sof, 2015-11-16 11:51:09]

Description was changed from

==========
Oilpan: tidier ContentSecurityPolicy back refs from auxillary CSP objects.

R=
BUG=553613
==========

to

==========
Oilpan: tidier ContentSecurityPolicy back refs from auxillary CSP objects.

R=haraken
BUG=553613
==========

[sof, 2015-11-16 13:05:59]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2015-11-16 13:05:59]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1436103004/#ps20001
(title: "add TODOs")

[commit-bot: I haz the power, 2015-11-16 13:06:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1436103004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1436103004/20001

[commit-bot: I haz the power, 2015-11-16 13:09:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-16 13:10:56]

Patchset 2 (id:??) landed as
https://crrev.com/b574c130b6a74c98e45e4331a04c02324c1770d2
Cr-Commit-Position: refs/heads/master@{#359831}