third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.h - Issue 1436103004: Oilpan: tidier ContentSecurityPolicy back refs from auxillary CSP objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.h

Issue 1436103004: Oilpan: tidier ContentSecurityPolicy back refs from auxillary CSP objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add TODOs Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/csp/CSPDirective.h ('k') | third_party/WebKit/Source/core/frame/csp/CSPSource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.h

diff --git a/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.h b/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.h

index d882248b8882d0f4eaa8af62eea38623bca5906e..aa1faa4048cb614535c626ba32b6f31d8854469e 100644

--- a/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.h

+++ b/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.h

@@ -9,6 +9,7 @@

#include "core/frame/csp/ContentSecurityPolicy.h"

#include "core/frame/csp/MediaListDirective.h"

#include "core/frame/csp/SourceListDirective.h"

+#include "platform/heap/Handle.h"

#include "platform/network/ContentSecurityPolicyParsers.h"

#include "platform/network/HTTPParsers.h"

#include "platform/weborigin/KURL.h"

@@ -123,7 +124,8 @@ private:

bool denyIfEnforcingPolicy() const { return m_reportOnly; }

- ContentSecurityPolicy* m_policy;

+ // TODO(Oilpan): consider moving ContentSecurityPolicy auxilliary objects to the heap.

+ RawPtrWillBeUntracedMember<ContentSecurityPolicy> m_policy;

String m_header;

ContentSecurityPolicyHeaderType m_headerType;

« no previous file with comments | « third_party/WebKit/Source/core/frame/csp/CSPDirective.h ('k') | third_party/WebKit/Source/core/frame/csp/CSPSource.h » ('j') | no next file with comments »