Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 1435873002: [turbofan] Initial support for constructor call inlining. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Initial support for constructor call inlining. This implements a first version of support for constructor call inlining in the inlining machinery. For now we can only inline calls where the actual constructor and the original constructor coincide (i.e. no super constructor calls). Note that the target of a super constructor call is loaded with a runtime call, so there is no way for it to be constant promoted at the moment. R=bmeurer@chromium.org BUG=v8:4544 LOG=n Committed: https://crrev.com/11d5d09ce16de756bd36babf7b4d22f81f490044 Cr-Commit-Position: refs/heads/master@{#31954}

Patch Set 1 #

Patch Set 2 : Fix size_t madness. #

Patch Set 3 : Fix unit test. #

Patch Set 4 : Fix schtupidness. #

Patch Set 5 : Disable three tests. #

Patch Set 6 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -72 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/code-generator.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/frame-states.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/frame-states.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/compiler/js-inlining.h View 1 2 chunks +5 lines, -6 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 7 chunks +99 lines, -44 lines 0 comments Download
M src/compiler/js-inlining-heuristic.cc View 1 2 3 4 5 5 chunks +12 lines, -9 lines 0 comments Download
M src/compiler/js-operator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/linkage.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M src/runtime/runtime-function.cc View 1 2 3 2 chunks +17 lines, -7 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 3 4 5 1 chunk +7 lines, -1 line 0 comments Download
M test/unittests/compiler/js-operator-unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 1 month ago (2015-11-11 13:37:37 UTC) #1
Benedikt Meurer
Nice. LGTM.
5 years, 1 month ago (2015-11-11 19:47:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435873002/90001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435873002/90001
5 years, 1 month ago (2015-11-12 08:49:26 UTC) #5
commit-bot: I haz the power
Committed patchset #6 (id:90001)
5 years, 1 month ago (2015-11-12 08:50:56 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:20:28 UTC) #7
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/11d5d09ce16de756bd36babf7b4d22f81f490044
Cr-Commit-Position: refs/heads/master@{#31954}

Powered by Google App Engine
This is Rietveld 408576698