Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 1434873004: [turbofan] Pass new target to JSCreate nodes. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_inlining-constructor-1
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Pass new target to JSCreate nodes. This passes both, the actual constructor and the original constructor, to nodes having the {JSCreate} operator. This is required for allocating properly subclassed implicit receiver objects. R=verwaest@chromium.org BUG=v8:4544 LOG=n Committed: https://crrev.com/bae4492a3e43f57b62a48756a61900532f4b47cf Cr-Commit-Position: refs/heads/master@{#31955}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M src/compiler/js-generic-lowering.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/compiler/js-operator.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-operator-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
Michael Starzinger
5 years, 1 month ago (2015-11-11 15:49:16 UTC) #3
Toon Verwaest
lgtm
5 years, 1 month ago (2015-11-11 16:27:16 UTC) #4
Benedikt Meurer
LGTM. On a (un)related note: Can we maybe use the spec term "new target" instead ...
5 years, 1 month ago (2015-11-11 19:46:18 UTC) #5
Michael Starzinger
On 2015/11/11 19:46:18, Benedikt Meurer wrote: > LGTM. > > On a (un)related note: Can ...
5 years, 1 month ago (2015-11-12 08:50:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434873004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434873004/1
5 years, 1 month ago (2015-11-12 09:15:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 09:33:36 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:20:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bae4492a3e43f57b62a48756a61900532f4b47cf
Cr-Commit-Position: refs/heads/master@{#31955}

Powered by Google App Engine
This is Rietveld 408576698