Issue 14358034: dbus: Use MockDBusThreadManagerWithoutGMock for InputMethodEngineIBusBrowserTest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14358034: dbus: Use MockDBusThreadManagerWithoutGMock for InputMethodEngineIBusBrowserTest (Closed)

Created:
7 years, 8 months ago by Haruki Sato

Modified:
7 years, 7 months ago

Reviewers:
Seigo Nonaka

CC:
chromium-reviews, nkostylev+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

dbus: Use MockDBusThreadManagerWithoutGMock for InputMethodEngineIBusBrowserTest This CL demonstrates a browser_test runnning without Gmock for DBusThreadManager. BUG=234084 TEST=trybots R=nona@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198868

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebased on 198838 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -29 lines)			Patch
	M	chrome/browser/chromeos/input_method/input_method_engine_ibus_browserttests.cc	View	1	3 chunks	+3 lines, -29 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Haruki Sato

This is the last piece of changes to use MockDBusThreadMaangerWithoutGMock for this browser_test. it depends ...

7 years, 8 months ago (2013-04-25 07:44:04 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haruki@chromium.org/14358034/4001

7 years, 7 months ago (2013-05-02 08:30:18 UTC) #3

Haruki Sato

7 years, 7 months ago (2013-05-08 09:40:33 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r198868 (presubmit successful).

Expand Messages | Collapse Messages