Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Side by Side Diff: chrome/browser/chromeos/input_method/input_method_engine_ibus_browserttests.cc

Issue 14358034: dbus: Use MockDBusThreadManagerWithoutGMock for InputMethodEngineIBusBrowserTest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased on 198838 Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind_helpers.h" 5 #include "base/bind_helpers.h"
6 #include "chrome/browser/chromeos/input_method/input_method_configuration.h" 6 #include "chrome/browser/chromeos/input_method/input_method_configuration.h"
7 #include "chrome/browser/extensions/extension_browsertest.h" 7 #include "chrome/browser/extensions/extension_browsertest.h"
8 #include "chrome/browser/extensions/extension_test_message_listener.h" 8 #include "chrome/browser/extensions/extension_test_message_listener.h"
9 #include "chromeos/dbus/dbus_thread_manager.h" 9 #include "chromeos/dbus/dbus_thread_manager.h"
10 #include "chromeos/dbus/ibus/mock_ibus_client.h" 10 #include "chromeos/dbus/ibus/mock_ibus_client.h"
11 #include "chromeos/dbus/ibus/mock_ibus_engine_factory_service.h" 11 #include "chromeos/dbus/ibus/mock_ibus_engine_factory_service.h"
12 #include "chromeos/dbus/ibus/mock_ibus_engine_service.h" 12 #include "chromeos/dbus/ibus/mock_ibus_engine_service.h"
13 #include "chromeos/dbus/mock_dbus_thread_manager.h" 13 #include "chromeos/dbus/mock_dbus_thread_manager_without_gmock.h"
14 #include "chromeos/dbus/mock_update_engine_client.h" 14 #include "chromeos/dbus/mock_update_engine_client.h"
15 #include "chromeos/ime/input_method_descriptor.h" 15 #include "chromeos/ime/input_method_descriptor.h"
16 #include "chromeos/ime/input_method_manager.h" 16 #include "chromeos/ime/input_method_manager.h"
17 #include "content/public/test/test_utils.h" 17 #include "content/public/test/test_utils.h"
18 #include "dbus/mock_bus.h" 18 #include "dbus/mock_bus.h"
19 19
20 // TODO(nona): Remove gmock dependency once crbug.com/223061 is fixed.
21 #include "testing/gmock/include/gmock/gmock.h"
22
23 using testing::Return;
24 using testing::_;
25
26 namespace chromeos { 20 namespace chromeos {
27 namespace input_method { 21 namespace input_method {
28 namespace { 22 namespace {
29 23
30 const char kIdentityIMEID[] = 24 const char kIdentityIMEID[] =
31 "_ext_ime_iafoklpfplgfnoimmaejoeondnjnlcfpIdentityIME"; 25 "_ext_ime_iafoklpfplgfnoimmaejoeondnjnlcfpIdentityIME";
32 const char kToUpperIMEID[] = 26 const char kToUpperIMEID[] =
33 "_ext_ime_iafoklpfplgfnoimmaejoeondnjnlcfpToUpperIME"; 27 "_ext_ime_iafoklpfplgfnoimmaejoeondnjnlcfpToUpperIME";
34 const char kEchoBackIMEID[] = 28 const char kEchoBackIMEID[] =
35 "_ext_ime_iafoklpfplgfnoimmaejoeondnjnlcfpEchoBackIME"; 29 "_ext_ime_iafoklpfplgfnoimmaejoeondnjnlcfpEchoBackIME";
(...skipping 15 matching lines...) Expand all
51 class InputMethodEngineIBusBrowserTest 45 class InputMethodEngineIBusBrowserTest
52 : public ExtensionBrowserTest, 46 : public ExtensionBrowserTest,
53 public ::testing::WithParamInterface<TestType> { 47 public ::testing::WithParamInterface<TestType> {
54 public: 48 public:
55 InputMethodEngineIBusBrowserTest() 49 InputMethodEngineIBusBrowserTest()
56 : ExtensionBrowserTest(), 50 : ExtensionBrowserTest(),
57 mock_dbus_thread_manager_(NULL) {} 51 mock_dbus_thread_manager_(NULL) {}
58 virtual ~InputMethodEngineIBusBrowserTest() {} 52 virtual ~InputMethodEngineIBusBrowserTest() {}
59 53
60 virtual void SetUpInProcessBrowserTestFixture() OVERRIDE { 54 virtual void SetUpInProcessBrowserTestFixture() OVERRIDE {
61 mock_dbus_thread_manager_ = new MockDBusThreadManager(); 55 mock_dbus_thread_manager_ = new MockDBusThreadManagerWithoutGMock();
62 DBusThreadManager::InitializeForTesting(mock_dbus_thread_manager_); 56 DBusThreadManager::InitializeForTesting(mock_dbus_thread_manager_);
63 ExtensionBrowserTest::SetUpInProcessBrowserTestFixture(); 57 ExtensionBrowserTest::SetUpInProcessBrowserTestFixture();
64
65 // Necessary for launching browser tests with MockDBusThreadManager.
66 // TODO(nona): Remove this once crbug.com/223061 is fixed.
67 EXPECT_CALL(*mock_dbus_thread_manager_->mock_update_engine_client(),
68 GetLastStatus())
69 .Times(1)
70 .WillOnce(Return(chromeos::MockUpdateEngineClient::Status()));
71
72 // TODO(nona): Remove this once crbug.com/223061 is fixed.
73 EXPECT_CALL(*mock_dbus_thread_manager_, InitIBusBus(_, _))
74 .WillOnce(Invoke(this,
75 &InputMethodEngineIBusBrowserTest::OnInitIBusBus));
76 } 58 }
77 59
78 virtual void TearDownInProcessBrowserTestFixture() OVERRIDE { 60 virtual void TearDownInProcessBrowserTestFixture() OVERRIDE {
79 DBusThreadManager::Shutdown(); 61 DBusThreadManager::Shutdown();
80 } 62 }
81 63
82 protected: 64 protected:
83 bool LoadExtensionWithType(const std::string& extension_name, 65 bool LoadExtensionWithType(const std::string& extension_name,
84 TestType type) { 66 TestType type) {
85 switch (type) { 67 switch (type) {
86 case kTestTypeNormal: 68 case kTestTypeNormal:
87 return LoadExtension(test_data_dir_.AppendASCII(extension_name)); 69 return LoadExtension(test_data_dir_.AppendASCII(extension_name));
88 case kTestTypeIncognito: 70 case kTestTypeIncognito:
89 return LoadExtensionIncognito( 71 return LoadExtensionIncognito(
90 test_data_dir_.AppendASCII(extension_name)); 72 test_data_dir_.AppendASCII(extension_name));
91 case kTestTypeComponent: 73 case kTestTypeComponent:
92 return LoadExtensionAsComponent( 74 return LoadExtensionAsComponent(
93 test_data_dir_.AppendASCII(extension_name)); 75 test_data_dir_.AppendASCII(extension_name));
94 } 76 }
95 NOTREACHED(); 77 NOTREACHED();
96 return false; 78 return false;
97 } 79 }
98 80
99 void OnInitIBusBus(const std::string& ibus_address, 81 MockDBusThreadManagerWithoutGMock* mock_dbus_thread_manager_;
100 const base::Closure& closure) {
101 dbus::Bus::Options options;
102 mock_bus_ = new dbus::MockBus(options);
103 EXPECT_CALL(*mock_dbus_thread_manager_, GetIBusBus())
104 .WillRepeatedly(Return(mock_bus_));
105 }
106
107 MockDBusThreadManager* mock_dbus_thread_manager_;
108 scoped_refptr<dbus::MockBus> mock_bus_; 82 scoped_refptr<dbus::MockBus> mock_bus_;
109 }; 83 };
110 84
111 class KeyEventDoneCallback { 85 class KeyEventDoneCallback {
112 public: 86 public:
113 explicit KeyEventDoneCallback(bool expected_argument) 87 explicit KeyEventDoneCallback(bool expected_argument)
114 : expected_argument_(expected_argument), 88 : expected_argument_(expected_argument),
115 is_called_(false) {} 89 is_called_(false) {}
116 ~KeyEventDoneCallback() {} 90 ~KeyEventDoneCallback() {}
117 91
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
224 198
225 // onDeactivated should be fired if Disable is called. 199 // onDeactivated should be fired if Disable is called.
226 ExtensionTestMessageListener disabled_listener("onDeactivated", false); 200 ExtensionTestMessageListener disabled_listener("onDeactivated", false);
227 engine_handler->Disable(); 201 engine_handler->Disable();
228 ASSERT_TRUE(disabled_listener.WaitUntilSatisfied()); 202 ASSERT_TRUE(disabled_listener.WaitUntilSatisfied());
229 } 203 }
230 204
231 } // namespace 205 } // namespace
232 } // namespace input_method 206 } // namespace input_method
233 } // namespace chromeos 207 } // namespace chromeos
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698