Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1435603003: Implemented the RoundInt64ToFloat32 TurboFan operator for x64, arm64, and mips64. (Closed)

Created:
5 years, 1 month ago by ahaas
Modified:
5 years, 1 month ago
Reviewers:
titzer, v8-mips-ports, akos.palfi.imgtec
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Implemented the RoundInt64ToFloat32 TurboFan operator for x64, arm64, and mips64. R=titzer@chromium.org Committed: https://crrev.com/1b535ca075d4818e4faf53157f3b3474a457adab Cr-Commit-Position: refs/heads/master@{#31929}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -0 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.h View 2 chunks +11 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M src/x64/disasm-x64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ahaas
5 years, 1 month ago (2015-11-10 11:48:48 UTC) #1
titzer
On 2015/11/10 11:48:48, ahaas wrote: lgtm
5 years, 1 month ago (2015-11-10 14:17:21 UTC) #3
akos.palfi.imgtec
MIPS part LGTM, thanks!
5 years, 1 month ago (2015-11-10 15:31:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435603003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435603003/1
5 years, 1 month ago (2015-11-10 20:36:52 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-10 20:39:22 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 20:40:05 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1b535ca075d4818e4faf53157f3b3474a457adab
Cr-Commit-Position: refs/heads/master@{#31929}

Powered by Google App Engine
This is Rietveld 408576698