Description was changed from
==========
Remove invert viewport scroll order setting from Blink
BUG=
==========
to
==========
Remove invert viewport scroll order setting from Blink
BUG=443724
==========
bokan
Description was changed from ========== Remove invert viewport scroll order setting from Blink BUG=443724 ========== ...
Description was changed from
==========
Remove invert viewport scroll order setting from Blink
BUG=443724
==========
to
==========
Remove invert viewport scroll order setting from Blink
Note: This setting was already removed on the Chromium side
in r348988 and set the Blink setting to always be true. This
patch just removes the now unused Blink branches.
BUG=443724
==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435233002/1
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/120185)
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435233002/1
5 years, 1 month ago
(2015-11-17 16:46:57 UTC)
#13
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/141846)
5 years, 1 month ago
(2015-11-17 17:37:42 UTC)
#15
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435233002/1
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/87844)
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435233002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435233002/40001
Description was changed from
==========
Remove invert viewport scroll order setting from Blink
Note: This setting was already removed on the Chromium side
in r348988 and set the Blink setting to always be true. This
patch just removes the now unused Blink branches.
BUG=443724
==========
to
==========
Remove invert viewport scroll order setting from Blink
Note: This setting was already removed on the Chromium side
in r348988 and set the Blink setting to always be true. This
patch just removes the now unused Blink branches.
BUG=443724
==========
Description was changed from
==========
Remove invert viewport scroll order setting from Blink
Note: This setting was already removed on the Chromium side
in r348988 and set the Blink setting to always be true. This
patch just removes the now unused Blink branches.
BUG=443724
==========
to
==========
Remove invert viewport scroll order setting from Blink
Note: This setting was already removed on the Chromium side
in r348988 and set the Blink setting to always be true. This
patch just removes the now unused Blink branches.
BUG=443724
Committed: https://crrev.com/82a9c12ebb952e773ee0db1f07aca6fb4d2b6dc9
Cr-Commit-Position: refs/heads/master@{#363625}
==========
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/82a9c12ebb952e773ee0db1f07aca6fb4d2b6dc9 Cr-Commit-Position: refs/heads/master@{#363625}
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1509783002/ by lambroslambrou@chromium.org.
The reason for reverting is: Speculatively reverting, as it might have caused
compile failures:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/5...
ninja explain: output
obj/third_party/WebKit/Source/core/gen/blink/bindings/core/v8/webcore_testing.V8Internals.o
older than most recent input
../../out/Release/gen/blink/core/testing/InternalSettingsGenerated.h (1449527421
vs 1449531710)
ninja explain:
obj/third_party/WebKit/Source/core/gen/blink/bindings/core/v8/webcore_testing.V8Internals.o
is dirty
ninja explain: output
obj/third_party/WebKit/Source/core/gen/blink/bindings/core/v8/webcore_testing.V8InternalSettings.o
older than most recent input
../../out/Release/gen/blink/core/testing/InternalSettingsGenerated.h (1449527414
vs 1449531710)
ninja explain:
obj/third_party/WebKit/Source/core/gen/blink/bindings/core/v8/webcore_testing.V8InternalSettings.o
is dirty
ninja explain: obj/third_party/WebKit/Source/core/libwebcore_testing.a is dirty
ninja explain: webkit_unit_tests is dirty
ninja explain: obj/third_party/WebKit/public/all_blink.actions_depends.stamp is
dirty
ninja explain: obj/third_party/WebKit/Source/core/libwebcore_testing.a is dirty
ninja explain: content_shell is dirty
ninja explain: obj/build/blink_tests.actions_depends.stamp is dirty
ninja explain: obj/third_party/WebKit/Source/core/libwebcore_testing.a is dirty
[1/7] CXX
obj/third_party/WebKit/Source/core/gen/blink/bindings/core/v8/webcore_testing.V8Internals.o
[2/7] CXX
obj/third_party/WebKit/Source/core/gen/blink/bindings/core/v8/webcore_testing.V8InternalSettings.o
[3/7] AR obj/third_party/WebKit/Source/core/libwebcore_testing.a
[4/7] LINK webkit_unit_tests
[5/7] LINK content_shell
[6/7] STAMP obj/third_party/WebKit/public/all_blink.actions_depends.stamp
[7/7] STAMP obj/build/blink_tests.actions_depends.stamp
Failing build because ninja reported work to do.
This means that after completing a compile, another was run and
it resulted in still having work to do (that is, a no-op build
wasn't a no-op). Consult the first "ninja explain:" line for a
likely culprit.
.
bokan
Attempting to reland now that crbug.com/531579 is purportedly fixed.
4 years, 11 months ago
(2016-01-04 18:32:05 UTC)
#28
Message was sent while issue was closed.
Attempting to reland now that crbug.com/531579 is purportedly fixed.
bokan
Description was changed from ========== Remove invert viewport scroll order setting from Blink Note: This ...
4 years, 11 months ago
(2016-01-04 18:32:14 UTC)
#29
Message was sent while issue was closed.
Description was changed from
==========
Remove invert viewport scroll order setting from Blink
Note: This setting was already removed on the Chromium side
in r348988 and set the Blink setting to always be true. This
patch just removes the now unused Blink branches.
BUG=443724
Committed: https://crrev.com/82a9c12ebb952e773ee0db1f07aca6fb4d2b6dc9
Cr-Commit-Position: refs/heads/master@{#363625}
==========
to
==========
Remove invert viewport scroll order setting from Blink
Note: This setting was already removed on the Chromium side
in r348988 and set the Blink setting to always be true. This
patch just removes the now unused Blink branches.
BUG=443724
Committed: https://crrev.com/82a9c12ebb952e773ee0db1f07aca6fb4d2b6dc9
Cr-Commit-Position: refs/heads/master@{#363625}
==========
bokan
The CQ bit was checked by bokan@chromium.org
4 years, 11 months ago
(2016-01-04 18:32:22 UTC)
#30
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435233002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435233002/100001
4 years, 11 months ago
(2016-01-04 18:34:48 UTC)
#32
Description was changed from ========== Remove invert viewport scroll order setting from Blink Note: This ...
4 years, 11 months ago
(2016-01-04 21:35:40 UTC)
#33
Message was sent while issue was closed.
Description was changed from
==========
Remove invert viewport scroll order setting from Blink
Note: This setting was already removed on the Chromium side
in r348988 and set the Blink setting to always be true. This
patch just removes the now unused Blink branches.
BUG=443724
Committed: https://crrev.com/82a9c12ebb952e773ee0db1f07aca6fb4d2b6dc9
Cr-Commit-Position: refs/heads/master@{#363625}
==========
to
==========
Remove invert viewport scroll order setting from Blink
Note: This setting was already removed on the Chromium side
in r348988 and set the Blink setting to always be true. This
patch just removes the now unused Blink branches.
BUG=443724
Committed: https://crrev.com/82a9c12ebb952e773ee0db1f07aca6fb4d2b6dc9
Cr-Commit-Position: refs/heads/master@{#363625}
==========
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 11 months ago
(2016-01-04 21:35:40 UTC)
#34
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
commit-bot: I haz the power
Description was changed from ========== Remove invert viewport scroll order setting from Blink Note: This ...
4 years, 11 months ago
(2016-01-04 21:36:24 UTC)
#35
Message was sent while issue was closed.
Description was changed from
==========
Remove invert viewport scroll order setting from Blink
Note: This setting was already removed on the Chromium side
in r348988 and set the Blink setting to always be true. This
patch just removes the now unused Blink branches.
BUG=443724
Committed: https://crrev.com/82a9c12ebb952e773ee0db1f07aca6fb4d2b6dc9
Cr-Commit-Position: refs/heads/master@{#363625}
==========
to
==========
Remove invert viewport scroll order setting from Blink
Note: This setting was already removed on the Chromium side
in r348988 and set the Blink setting to always be true. This
patch just removes the now unused Blink branches.
BUG=443724
Committed: https://crrev.com/82a9c12ebb952e773ee0db1f07aca6fb4d2b6dc9
Cr-Commit-Position: refs/heads/master@{#363625}
Committed: https://crrev.com/993ed1a7d9f986c1c87f0368003b2baf0589ffb0
Cr-Commit-Position: refs/heads/master@{#367373}
==========
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/993ed1a7d9f986c1c87f0368003b2baf0589ffb0 Cr-Commit-Position: refs/heads/master@{#367373}
4 years, 11 months ago
(2016-01-04 21:36:24 UTC)
#36
Issue 1435233002: Remove invert viewport scroll order setting from Blink
(Closed)
Created 5 years, 1 month ago by bokan
Modified 4 years, 11 months ago
Reviewers: Rick Byers, Avi (use Gerrit), rjkroege
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 0