Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 1435233002: Remove invert viewport scroll order setting from Blink (Closed)

Created:
5 years, 1 month ago by bokan
Modified:
4 years, 11 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, blink-reviews, dglazkov+blink, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, blink-reviews-api_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove invert viewport scroll order setting from Blink Note: This setting was already removed on the Chromium side in r348988 and set the Blink setting to always be true. This patch just removes the now unused Blink branches. BUG=443724 Committed: https://crrev.com/82a9c12ebb952e773ee0db1f07aca6fb4d2b6dc9 Cr-Commit-Position: refs/heads/master@{#363625} Committed: https://crrev.com/993ed1a7d9f986c1c87f0368003b2baf0589ffb0 Cr-Commit-Position: refs/heads/master@{#367373}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fixed broken unit tests #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Patch Set 6 : Build fix after rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -68 lines) Patch
M components/html_viewer/blink_settings_impl.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RootFrameViewport.h View 1 2 3 3 chunks +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RootFrameViewport.cpp View 1 2 3 4 2 chunks +7 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RootFrameViewportTest.cpp View 1 2 3 4 chunks +16 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Settings.in View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.cpp View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/web/WebSettingsImpl.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSettingsImpl.cpp View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/tests/VisualViewportTest.cpp View 1 2 3 1 chunk +1 line, -7 lines 0 comments Download
M third_party/WebKit/public/web/WebSettings.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 36 (18 generated)
bokan
rbyers@chromium.org for public/web avi@chromium.org: for content rjkroege@chromium.org: for html_viewer
5 years, 1 month ago (2015-11-13 03:08:30 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435233002/1
5 years, 1 month ago (2015-11-13 03:11:08 UTC) #6
rjkroege
On 2015/11/13 03:11:08, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
5 years, 1 month ago (2015-11-13 03:18:53 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/120185)
5 years, 1 month ago (2015-11-13 03:33:34 UTC) #9
Avi (use Gerrit)
lgtm 🎉👍
5 years, 1 month ago (2015-11-13 15:54:06 UTC) #10
Rick Byers
LGTM
5 years, 1 month ago (2015-11-14 03:57:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435233002/1
5 years, 1 month ago (2015-11-17 16:46:57 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/141846)
5 years, 1 month ago (2015-11-17 17:37:42 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435233002/1
5 years ago (2015-12-04 20:33:12 UTC) #17
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/87844)
5 years ago (2015-12-04 21:36:24 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435233002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435233002/40001
5 years ago (2015-12-07 21:26:50 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-07 23:26:30 UTC) #24
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/82a9c12ebb952e773ee0db1f07aca6fb4d2b6dc9 Cr-Commit-Position: refs/heads/master@{#363625}
5 years ago (2015-12-07 23:27:27 UTC) #26
Lambros
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1509783002/ by lambroslambrou@chromium.org. ...
5 years ago (2015-12-08 00:04:43 UTC) #27
bokan
Attempting to reland now that crbug.com/531579 is purportedly fixed.
4 years, 11 months ago (2016-01-04 18:32:05 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435233002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435233002/100001
4 years, 11 months ago (2016-01-04 18:34:48 UTC) #32
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 11 months ago (2016-01-04 21:35:40 UTC) #34
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 21:36:24 UTC) #36
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/993ed1a7d9f986c1c87f0368003b2baf0589ffb0
Cr-Commit-Position: refs/heads/master@{#367373}

Powered by Google App Engine
This is Rietveld 408576698