Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: third_party/WebKit/Source/core/frame/RootFrameViewport.h

Issue 1435233002: Remove invert viewport scroll order setting from Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Build fix after rebase Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/RootFrameViewport.h
diff --git a/third_party/WebKit/Source/core/frame/RootFrameViewport.h b/third_party/WebKit/Source/core/frame/RootFrameViewport.h
index ef6f90ebb3c7b96a5c0cc8023526e1efdb74f650..7407c868f6cb2202a48a35e0d6130e4cad02350a 100644
--- a/third_party/WebKit/Source/core/frame/RootFrameViewport.h
+++ b/third_party/WebKit/Source/core/frame/RootFrameViewport.h
@@ -25,9 +25,9 @@ class CORE_EXPORT RootFrameViewport final : public NoBaseWillBeGarbageCollectedF
USING_FAST_MALLOC_WILL_BE_REMOVED(RootFrameViewport);
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(RootFrameViewport);
public:
- static PassOwnPtrWillBeRawPtr<RootFrameViewport> create(ScrollableArea& visualViewport, ScrollableArea& layoutViewport, bool invertScrollOrder = false)
+ static PassOwnPtrWillBeRawPtr<RootFrameViewport> create(ScrollableArea& visualViewport, ScrollableArea& layoutViewport)
{
- return adoptPtrWillBeNoop(new RootFrameViewport(visualViewport, layoutViewport, invertScrollOrder));
+ return adoptPtrWillBeNoop(new RootFrameViewport(visualViewport, layoutViewport));
}
DECLARE_VIRTUAL_TRACE();
@@ -73,7 +73,7 @@ public:
Widget* widget() override;
private:
- RootFrameViewport(ScrollableArea& visualViewport, ScrollableArea& layoutViewport, bool invertScrollOrder);
+ RootFrameViewport(ScrollableArea& visualViewport, ScrollableArea& layoutViewport);
DoublePoint scrollOffsetFromScrollAnimators() const;
@@ -89,10 +89,6 @@ private:
RawPtrWillBeMember<ScrollableArea> m_visualViewport;
RawPtrWillBeMember<ScrollableArea> m_layoutViewport;
-
- // Experimental flag. If the experiment is enabled, scroll the visual viewport first,
- // the bubble scrolls to the layout viewport.
- bool m_invertScrollOrder;
};
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/core/frame/RootFrameViewport.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698